WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
57288
Move libtess from WebCore/thirdparty to ThirdParty
https://bugs.webkit.org/show_bug.cgi?id=57288
Summary
Move libtess from WebCore/thirdparty to ThirdParty
Adam Barth
Reported
2011-03-28 17:25:37 PDT
Move libtess from WebCore/thirdparty to ThirdParty
Attachments
work in progress
(286.03 KB, patch)
2011-03-28 17:28 PDT
,
Adam Barth
no flags
Details
Formatted Diff
Diff
patch
(286.19 KB, patch)
2011-03-28 18:25 PDT
,
Adam Barth
kbr
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2011-03-28 17:28:34 PDT
Created
attachment 87243
[details]
work in progress
Adam Barth
Comment 2
2011-03-28 17:29:18 PDT
@kbr: Thoughts on execution? I wasn't sure whether to trim "ThirdParty" from the include path...
Adam Barth
Comment 3
2011-03-28 18:25:46 PDT
Created
attachment 87247
[details]
patch
Adam Barth
Comment 4
2011-03-28 18:28:39 PDT
Comment on
attachment 87247
[details]
patch Marking for review b/c it builds locally.
Kenneth Russell
Comment 5
2011-03-29 12:02:14 PDT
Comment on
attachment 87247
[details]
patch Thanks for moving and cleaning this up. It basically looks fine. There are some files which aren't showing up in the patch such as LICENSE.txt and GNUmakefile. I assume that these files do exist in the new directory and that they're just not showing up in the patch because there were no changes to the content. As long as you manually verify that all of the files exist in the new directory it looks good to me.
Adam Barth
Comment 6
2011-04-12 14:39:22 PDT
Fixed in
http://trac.webkit.org/changeset/83641
and
http://trac.webkit.org/changeset/83642
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug