Bug 57285 – Remove specialization of EventDispatcher with inversion of control.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dimitri Glazkov (Google)]

Remove specialization of EventDispatcher with inversion of control.

[Dimitri Glazkov (Google)]

Created attachment 87237 [details]
Patch

[WebKit Review Bot]

Attachment 87237 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/dom/KeyboardEvent.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dimitri Glazkov (Google)]

(In reply to comment #2)
> Attachment 87237 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
> 
> Source/WebCore/dom/KeyboardEvent.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
> Total errors found: 1 in 8 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Don't be sad, style elf. This file is old, and I am just adding one line to it.

[Eric Seidel (no email)]

Comment on attachment 87237 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87237&action=review

> Source/WebCore/dom/EventDispatcher.cpp:61
>  bool EventDispatcher::dispatchEvent(Node* node, PassRefPtr<Event> event)
>  {
>      EventDispatcher dispatcher(node);
> -    return dispatcher.dispatchEvent(event);
> +    RefPtr<Event> dispatchedEvent = event;
> +    return dispatchedEvent->dispatch(&dispatcher);
>  }

So this will eventually go away?

[Dimitri Glazkov (Google)]

Comment on attachment 87237 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87237&action=review

>> Source/WebCore/dom/EventDispatcher.cpp:61
>>  }
> 
> So this will eventually go away?

No, that's the only thing that'll stay.

[Eric Seidel (no email)]

Comment on attachment 87237 [details]
Patch

OK.  I'm not 100% convinced of the direction, but I trust you, and would like to let you paint your picture so we can all see it!

[Dimitri Glazkov (Google)]

Committed r82264: <http://trac.webkit.org/changeset/82264>

[WebKit Review Bot]

http://trac.webkit.org/changeset/82264 might have broken GTK Linux 32-bit Release
The following tests are not passing:
fast/loader/onload-willSendRequest-null-for-frame.html