Bug 57279 – WebKit2 bundle page needs to offer generated file hooks

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Darin Adler]

WebKit2 page bundle needs to offer generated file hooks

[Darin Adler]

Created attachment 87221 [details]
Patch

[Early Warning System Bot]

Attachment 87221 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8273522

[Darin Adler]

Comment on attachment 87221 [details]
Patch

Forgot to include the WebKitTestRunner part of the patch. Uploading a copy with that in it soon.

[Darin Adler]

Created attachment 87245 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 87245 [details]
Patch

Presumably the two MiniBrowser implementations need to be updated as well.

[Darin Adler]

(In reply to comment #5)
> Presumably the two MiniBrowser implementations need to be updated as well.

I’ll check. But maybe not if they don’t have a UI client at all. I searched for the name of the struct I changed in the entire tree and did not get any hits on MiniBrowser.

[Darin Adler]

Committed r82289: <http://trac.webkit.org/changeset/82289>

[Csaba Osztrogonác]

(In reply to comment #7)
> Committed r82289: <http://trac.webkit.org/changeset/82289>

It broke WTR build because of missing initializers for members:

/home/oszi/WebKit/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: In constructor ‘WTR::InjectedBundlePage::InjectedBundlePage(const OpaqueWKBundlePage*)’:

/home/oszi/WebKit/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:216: error: missing initializer for member ‘WKBundlePageUIClient::shouldGenerateFileForUpload’

/home/oszi/WebKit/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:216: error: missing initializer for member ‘WKBundlePageUIClient::generateFileForUpload’

[Csaba Osztrogonác]

I landed the missing part of the patch: http://trac.webkit.org/changeset/82302

[Darin Adler]

Sorry about not landing that part! I am not sure why webkit-patch didn’t land it. Last time I had this problem, someone told me it was due to Maciej’s changes to work only within a certain directory, and I can’t prove that didn’t happen this time, but I don’t think it did.