57271 – Min width at which video controls hide buttons changed

RESOLVED INVALID 57271

Min width at which video controls hide buttons changed

https://bugs.webkit.org/show_bug.cgi?id=57271

Summary Min width at which video controls hide buttons changed

Simon Fraser (smfr)

Reported 2011-03-28 14:51:25 PDT

At some point the min <video> width at which the controls hide some of the buttons changed. It used to be around 240px, and now it's about 263px.

Attachments
Add attachment proposed patch, testcase, etc.

Dimitri Glazkov (Google)

Comment 1 2011-03-28 14:54:32 PDT

I did that! The comment around the logic of controls was implying that we want to have a minimum width of the timeline at 100px, but the the logic was fudged up and it was less than that. Now it should switch exactly at 100px.

Dimitri Glazkov (Google)

Comment 2 2011-03-28 14:57:08 PDT

Here's the line I mentioned: http://google.com/codesearch/p#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/rendering/MediaControlElements.cpp&l=969&exact_package=chromium

Simon Fraser (smfr)

Comment 3 2011-03-28 15:01:07 PDT

OK.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution INVALID

Priority P2

Severity Normal

Classification Unclassified

Version 528+ (Nightly build)

Hardware Mac

OS OS X 10.5

Product WebKit

Component Media

Assignee

Nobody

Reported

2011-03-28 14:51 PDT

Modified

2011-03-28 15:01 PDT History

CC List

3 users Show

URL

Keywords

Depends on

Blocks