Bug 57266 – getComputedStyle counterIncrement crash @ WebCore::counterToCSSValue

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Emil A Eklund]

Chrome Version       : 11.0.696.16 beta
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 5:
Firefox 3.x:
IE 7/8:

What steps will reproduce the problem?
  view the attached file "a.html" in chrome

What is the expected result?
  an alert popup with some value

What happens instead?
  "Aw, Snap!"


Downstream chrome bug: http://code.google.com/p/chromium/issues/detail?id=77665

[Emil A Eklund]

This is a NULL pointer crash in WebCore::counterToCSSValue.

[Emil A Eklund]

Created attachment 87205 [details]
Test case

[Emil A Eklund]

Created attachment 87206 [details]
Patch

[Darin Adler]

Comment on attachment 87206 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87206&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:775
> +        return NULL;

We use 0, not NULL, in the WebKit project.

[WebKit Review Bot]

Attachment 87206 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

Source/WebCore/css/CSSComputedStyleDeclaration.cpp:775:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Emil A Eklund]

Created attachment 87209 [details]
Patch

Of course, my bad. Old habit, takes some time to retrain.

[WebKit Commit Bot]

Comment on attachment 87209 [details]
Patch

Clearing flags on attachment: 87209

Committed r82222: <http://trac.webkit.org/changeset/82222>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.