Bug 57263 - CGImageRefs must hold a strong reference to underlying data
Summary: CGImageRefs must hold a strong reference to underlying data
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-28 13:29 PDT by Anders Carlsson
Modified: 2011-03-28 13:58 PDT (History)
3 users (show)

See Also:

Attachments
Patch (11.80 KB, patch)
2011-03-28 13:32 PDT, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-03-28 13:29:18 PDT 
CGImageRefs must hold a strong reference to underlying data
Comment 1 Anders Carlsson 2011-03-28 13:32:59 PDT 
Created attachment 87191 [details]
Patch
Comment 2 Sam Weinig 2011-03-28 13:35:51 PDT 
Comment on attachment 87191 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87191&action=review

> Source/WebKit2/Shared/cg/ShareableBitmapCG.cpp:58
> +RetainPtr<CGImageRef> ShareableBitmap::createCGImageCopy()

Lets call this makeCGImage.

> Source/WebKit2/Shared/cg/ShareableBitmapCG.cpp:65
> +RetainPtr<CGImageRef> ShareableBitmap::createCGImage()

This one too.
Comment 3 Anders Carlsson 2011-03-28 13:46:04 PDT 
Committed r82151: <http://trac.webkit.org/changeset/82151>
Comment 4 WebKit Review Bot 2011-03-28 13:58:58 PDT 
http://trac.webkit.org/changeset/82151 might have broken Windows Release (Build) and Windows Debug (Build)