Bug 57257 - Use willCacheResponse on Windows instead of shouldCacheResponse
: Use willCacheResponse on Windows instead of shouldCacheResponse
Status: NEW
: WebKit
Platform
: 528+ (Nightly build)
: PC Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-03-28 11:50 PST by
Modified: 2011-03-28 11:50 PST (History)


Attachments


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-03-28 11:50:55 PST
ResourceLoader.h has two different callback methods.

On Mac - virtual NSCachedURLResponse* willCacheResponse(ResourceHandle*, NSCachedURLResponse*);
On Windows - virtual bool shouldCacheResponse(ResourceHandle*, CFCachedURLResponseRef);

The method on Windows should match the one on Mac. It should be

virtual CFCachedURLResponseRef willCacheResponse(ResourceHandle*, CFCachedURLResponseRef);

I am adding the above method for Mac when using CFNetwork (see bug 51836). Windows code should use that.