WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
57257
Use willCacheResponse on Windows instead of shouldCacheResponse
https://bugs.webkit.org/show_bug.cgi?id=57257
Summary
Use willCacheResponse on Windows instead of shouldCacheResponse
Pratik Solanki
Reported
2011-03-28 11:50:55 PDT
ResourceLoader.h has two different callback methods. On Mac - virtual NSCachedURLResponse* willCacheResponse(ResourceHandle*, NSCachedURLResponse*); On Windows - virtual bool shouldCacheResponse(ResourceHandle*, CFCachedURLResponseRef); The method on Windows should match the one on Mac. It should be virtual CFCachedURLResponseRef willCacheResponse(ResourceHandle*, CFCachedURLResponseRef); I am adding the above method for Mac when using CFNetwork (see
bug 51836
). Windows code should use that.
Attachments
Add attachment
proposed patch, testcase, etc.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug