Bug 57257 - Use willCacheResponse on Windows instead of shouldCacheResponse
Summary: Use willCacheResponse on Windows instead of shouldCacheResponse
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2011-03-28 11:50 PDT by Pratik Solanki
Modified: 2011-03-28 11:50 PDT (History)
4 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Pratik Solanki 2011-03-28 11:50:55 PDT
ResourceLoader.h has two different callback methods.

On Mac - virtual NSCachedURLResponse* willCacheResponse(ResourceHandle*, NSCachedURLResponse*);
On Windows - virtual bool shouldCacheResponse(ResourceHandle*, CFCachedURLResponseRef);

The method on Windows should match the one on Mac. It should be

virtual CFCachedURLResponseRef willCacheResponse(ResourceHandle*, CFCachedURLResponseRef);

I am adding the above method for Mac when using CFNetwork (see bug 51836). Windows code should use that.