Bug 57256 - Fix crash on Solaris 10 for misaligned reads on Sparc processors
Summary: Fix crash on Solaris 10 for misaligned reads on Sparc processors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-28 11:49 PDT by Ben Taylor
Modified: 2011-06-03 07:19 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch which compiles correctly in qt-4.7.2 with webkit enabled on Solaris 10 with SS12 C++ compiler (1.30 KB, patch)
2011-03-28 13:15 PDT, Ben Taylor 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Taylor 2011-03-28 11:49:09 PDT 
Sparc cannot do 32-bit reads on misaligned boundaries. The program
crashes if you try to do so.

t@1 (l@1) signal BUS (invalid address alignment) in WebCore::equal at 0xffffffff7e2719fc
0xffffffff7e2719fc: equal+0x002c:       ld       [%o1], %g1

(originally reported from https://bugs.webkit.org/show_bug.cgi?id=24932
by Thiago Macieria, patch 05/17)
Comment 1 Ben Taylor 2011-03-28 13:15:34 PDT 
Created attachment 87185 [details]
Proposed patch which compiles correctly in qt-4.7.2 with webkit enabled on Solaris 10 with SS12 C++ compiler

Fix crash on misaligned reads on Solaris 10/Sparc. Original bug reported
and proposed fix by Thiago Macieria in bug https://bugs.webkit.org/show_bug.cgi?id=24932
Comment 2 WebKit Commit Bot 2011-03-29 00:59:37 PDT 
Comment on attachment 87185 [details]
Proposed patch which compiles correctly in qt-4.7.2 with webkit enabled on Solaris 10 with SS12 C++ compiler

Clearing flags on attachment: 87185

Committed r82207: <http://trac.webkit.org/changeset/82207>
Comment 3 WebKit Commit Bot 2011-03-29 00:59:40 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Ademar Reis 2011-06-03 07:19:30 PDT 
Looks like the patch attached to this bug was incomplete. See bug 29407, I attached a patch there with the missing checks.