Bug 57255 - [chromium] have DRT write the png checksum into a png comment
Summary: [chromium] have DRT write the png checksum into a png comment
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks: 56286
  Show dependency tree / graph
 
Reported: 2011-03-28 11:45 PDT by Tony Chang
Modified: 2011-03-28 16:49 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.90 KB, patch)
2011-03-28 11:46 PDT, Tony Chang 		abarth: review+
abarth: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2011-03-28 11:45:52 PDT 
[chromium] have DRT write the png checksum into a png comment
Comment 1 Tony Chang 2011-03-28 11:46:49 PDT 
Created attachment 87175 [details]
Patch
Comment 2 Tony Chang 2011-03-28 11:48:38 PDT 
There will be follow up changes for NRWT and the rebaseline tool.
Comment 3 Adam Barth 2011-03-28 16:26:11 PDT 
Comment on attachment 87175 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87175&action=review

> Tools/DumpRenderTree/chromium/TestShell.cpp:561
> -            static_cast<int>(sourceBitmap.rowBytes()), discardTransparency, &png);
> +            static_cast<int>(sourceBitmap.rowBytes()), discardTransparency,
> +            md5hash, &png);

This should be on one line.
Comment 4 Tony Chang 2011-03-28 16:49:18 PDT 
Committed r82174: <http://trac.webkit.org/changeset/82174>