Bug 57249 - MediaPlayerPrivateAVFoundation should report that it supportsFullScreen()
Summary: MediaPlayerPrivateAVFoundation should report that it supportsFullScreen()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-03-28 10:42 PDT by Jer Noble
Modified: 2011-03-31 01:28 PDT (History)
0 users

See Also:

Attachments
Patch (12.50 KB, patch)
2011-03-28 13:25 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (14.30 KB, patch)
2011-03-28 13:26 PDT, Jer Noble 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2011-03-28 10:42:55 PDT 
With the FULLSCREEN_API changes, media players need not do anything special to support full screen; so when it is enabled, AVFoundation should return true for supportsFullScreen().
Comment 1 Jer Noble 2011-03-28 12:01:54 PDT 
<rdar://problem/9197629>
Comment 2 Jer Noble 2011-03-28 13:25:31 PDT 
Created attachment 87189 [details]
Patch
Comment 3 Darin Adler 2011-03-28 13:26:28 PDT 
Comment on attachment 87189 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87189&action=review

> Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:393
> +    // FIXME: WebVideoFullscreenController assumes a QTKit/QuickTime media engine

I don’t understand this FIXME.
Comment 4 Jer Noble 2011-03-28 13:26:55 PDT 
Created attachment 87190 [details]
Patch

Now with 200% more ChangeLogs\!
Comment 5 Jer Noble 2011-03-28 13:34:20 PDT 
Comment on attachment 87189 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87189&action=review

>> Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:393
>> +    // FIXME: WebVideoFullscreenController assumes a QTKit/QuickTime media engine
> 
> I don’t understand this FIXME.

I moved the FIXME here from the header.  Our previous full screen implementation (WebVideoFullscreenController) relies on QTKit, as a single QTMovie can drive multiple QTMovieLayers.  But this means the implementation is specific to a QTKit-backed MediaPlayer.  If FULLSCREEN_API is not enabled, it would be unsafe to return "true" here without addressing the underlying assumptions made by WebVideoFullscreenController.
Comment 6 Jer Noble 2011-03-28 15:31:59 PDT 
Committed r82167: <http://trac.webkit.org/changeset/82167>