Bug 57240 - Web Inspector: brush up and rename debugger domain.
: Web Inspector: brush up and rename debugger domain.
Status: RESOLVED FIXED
: WebKit
Web Inspector (Deprecated)
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-03-28 09:33 PST by
Modified: 2011-03-30 02:35 PST (History)


Attachments
Patch (38.31 KB, patch)
2011-03-28 09:49 PST, Pavel Feldman
yurys: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-03-28 09:33:32 PST
Patch to follow.
------- Comment #1 From 2011-03-28 09:49:50 PST -------
Created an attachment (id=87155) [details]
Patch
------- Comment #2 From 2011-03-28 09:58:22 PST -------
Attachment 87155 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8272553
------- Comment #3 From 2011-03-28 09:58:31 PST -------
(From update of attachment 87155 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=87155&action=review

> Source/WebCore/inspector/Inspector.json:1228
> +                "name": "scriptFailedToParse",

scriptParsingFailed

> Source/WebCore/inspector/InspectorDebuggerAgent.cpp:181
> +void InspectorDebuggerAgent::setBreakpoint(ErrorString*, const String& sourceId, int lineNumber, int columnNumber, const String& condition, bool enabled, String* outBreakpointId, int* actualLineNumber, int* actualColumnNumber)

setBreakpointBySourceId?
------- Comment #4 From 2011-03-28 10:17:21 PST -------
Committed r82131: <http://trac.webkit.org/changeset/82131>
------- Comment #5 From 2011-03-28 10:24:26 PST -------
http://trac.webkit.org/changeset/82131 might have broken Chromium Linux Release
------- Comment #6 From 2011-03-30 02:35:08 PST -------
View in context: https://bugs.webkit.org/attachment.cgi?id=87155&action=review

> Source/WebCore/inspector/front-end/DebuggerModel.js:182
> +    _didEditScriptSource: function(sourceID, callback, error, error, newBody, callFrames)

ERROR: redefinition of "error" variable. It breaks handling JS backend compile errors in live edit.