Bug 57240 - Web Inspector: brush up and rename debugger domain.
: Web Inspector: brush up and rename debugger domain.
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated)
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Nobody
Depends on:
  Show dependency treegraph
Reported: 2011-03-28 09:33 PDT by Pavel Feldman
Modified: 2011-03-30 02:35 PDT (History)
15 users (show)

See Also:

Patch (38.31 KB, patch)
2011-03-28 09:49 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-03-28 09:33:32 PDT
Patch to follow.
Comment 1 Pavel Feldman 2011-03-28 09:49:50 PDT
Created attachment 87155 [details]
Comment 2 WebKit Review Bot 2011-03-28 09:58:22 PDT
Attachment 87155 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8272553
Comment 3 Yury Semikhatsky 2011-03-28 09:58:31 PDT
Comment on attachment 87155 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=87155&action=review

> Source/WebCore/inspector/Inspector.json:1228
> +                "name": "scriptFailedToParse",


> Source/WebCore/inspector/InspectorDebuggerAgent.cpp:181
> +void InspectorDebuggerAgent::setBreakpoint(ErrorString*, const String& sourceId, int lineNumber, int columnNumber, const String& condition, bool enabled, String* outBreakpointId, int* actualLineNumber, int* actualColumnNumber)

Comment 4 Pavel Feldman 2011-03-28 10:17:21 PDT
Committed r82131: <http://trac.webkit.org/changeset/82131>
Comment 5 WebKit Review Bot 2011-03-28 10:24:26 PDT
http://trac.webkit.org/changeset/82131 might have broken Chromium Linux Release
Comment 6 Andrey Adaikin 2011-03-30 02:35:08 PDT
View in context: https://bugs.webkit.org/attachment.cgi?id=87155&action=review

> Source/WebCore/inspector/front-end/DebuggerModel.js:182
> +    _didEditScriptSource: function(sourceID, callback, error, error, newBody, callFrames)

ERROR: redefinition of "error" variable. It breaks handling JS backend compile errors in live edit.