Created attachment 87153 [details] Patch Reviewed by NOBODY (OOPS!). Adding a "using namespace WebCore;" statement in a header may cause issues when <WebCore/Length.h> is included before <CoreText/CoreText.h>. Length.h defines the LengthType enum with a 'Fixed' value. CoreText.h includes MacTypes.h, which has a "typedef SInt32 Fixed;" statement, and then CoreText.h includes other headers that also use 'Fixed', but expect the typedef to be defined, not the enum. If another header includes "using namespace WebCore;" before CoreText.h, the following compiler errors result (paths abbreviated): CoreText.framework/Headers/SFNTLayoutTypes.h:689: error: reference to 'Fixed' is ambiguous MacTypes.h:184: error: candidates are: typedef SInt32 Fixed Length.h:37: error: WebCore::LengthType WebCore::Fixed SFNTLayoutTypes.h:689: error: 'Fixed' does not name a type * platform/mac/HTMLConverter.h: Use forward declaration of DocumentLoader class instead of including header. Remove the unused "using namespace WebCore;" statement. --- 2 files changed, 31 insertions(+), 3 deletions(-)
Attachment 87153 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
I filed Bug 57241 about check-webkit-style flagging "using namespace Foo;" statements in headers.
<rdar://problem/9192997>
(In reply to comment #1) > Attachment 87153 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 > > Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] > Total errors found: 1 in 2 files > > If any of these errors are false positives, please file a bug against check-webkit-style. I want webkit-patch to support a placeholder for the bug number. I filed: Bug 57242.
Committed r82128: <http://trac.webkit.org/changeset/82128>
http://trac.webkit.org/changeset/82128 might have broken Leopard Intel Debug (Tests)