Bug 57235 - Web Inspector: [Chromium] Fix detailed heap snapshots UI
Summary: Web Inspector: [Chromium] Fix detailed heap snapshots UI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mikhail Naganov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-28 08:10 PDT by Mikhail Naganov
Modified: 2011-03-29 05:34 PDT (History)
13 users (show)

See Also:

Attachments
patch (4.06 KB, patch)
2011-03-28 08:13 PDT, Mikhail Naganov 		pfeldman: review+
mnaganov: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Naganov 2011-03-28 08:10:06 PDT 
Fix two problems:
 1. Text color of grid cells under selection needs to be white, otherwise it's unreadable for some colors;
 2. Long strings need to be truncated in grid, their contents can be shown on hover.
Comment 1 Mikhail Naganov 2011-03-28 08:13:04 PDT 
Created attachment 87146 [details]
patch
Comment 2 Mikhail Naganov 2011-03-29 04:35:56 PDT 
Manually committed http://trac.webkit.org/changeset/82229


2011-03-29  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Fix detailed heap snapshots UI.
        https://bugs.webkit.org/show_bug.cgi?id=57235

        Fix two problems:
          1. Text color of grid cells under selection needs to be white, otherwise it's unreadable for some colors;
          2. Long strings need to be truncated in grid, their contents can be shown on hover.

        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.DetailedHeapshotView.prototype._getHoverAnchor):
        (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup):
        * inspector/front-end/heapProfiler.css:
        (.detailed-heapshot-view .console-formatted-string):
        (.detailed-heapshot-view .data-grid tr.selected *):
        (.detailed-heapshot-view .data-grid:focus tr.selected *):
Comment 3 WebKit Review Bot 2011-03-29 05:34:51 PDT 
http://trac.webkit.org/changeset/82229 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
svg/text/text-deco-01-b.svg