we should provide a directionOfEnclosingBlock(Node*) so that it could be reused in SelectionController and other functions in visible_units.cpp, such as moving caret by word in visual order (which needs to know the direction of box and enclosing block, and the caret movement direction).
Created attachment 87147 [details] patch
Comment on attachment 87147 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=87147&action=review > Source/WebCore/editing/SelectionController.cpp:339 > + return WebCore::directionOfEnclosingBlock(m_selection.extent().anchorNode()); This isn't right. You're calling anchorNode() here even though the original code called containerNode().
Created attachment 87149 [details] patch
Comment on attachment 87149 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=87149&action=review > Source/WebCore/ChangeLog:8 > + Provide global function directionOfEnclosingBlock(Node*) so that it could be > + reused in SelectionController and other functionalities that need enclosing > + block's direcionality, such as moving caret by word in visual order. > + https://bugs.webkit.org/show_bug.cgi?id=57233. This isn't really a standard way of writing a change long entry. Please do: move directionOfEnclosingBlock() to be global so that it could be reused https://bugs.webkit.org/show_bug.cgi?id=57233 Provide global function directionOfEnclosingBlock(Node*) so that it could be reused in SelectionController and other functionalities that need enclosing block's direcionality, such as moving caret by word in visual order.
Committed r82121: <http://trac.webkit.org/changeset/82121>