Bug 57229 - Web Inspector: execution line is displayed incorrectly after source editing.
Summary: Web Inspector: execution line is displayed incorrectly after source editing.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Adaikin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-28 06:18 PDT by Pavel Podivilov
Modified: 2011-03-31 04:31 PDT (History)
9 users (show)

See Also:

Attachments
Patch (4.32 KB, patch)
2011-03-29 08:04 PDT, Andrey Adaikin 		no flags Details | Formatted Diff | Diff
Patch (8.98 KB, patch)
2011-03-30 02:42 PDT, Andrey Adaikin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-03-28 06:18:28 PDT 
Web Inspector: execution line is displayed incorrectly after source editing.

1. Pause on a breakpoint
2. Edit source above the execution line
3. Editor execution line decoration is moved while gutter decoration is not.
Comment 1 Andrey Adaikin 2011-03-29 08:04:12 PDT 
Created attachment 87331 [details]
Patch
Comment 2 Pavel Feldman 2011-03-29 08:37:54 PDT 
Comment on attachment 87331 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87331&action=review

> Source/WebCore/inspector/front-end/SourceFrame.js:188
> +        if (this._executionLineNumber !== undefined) {

I often use typeof this._executionLineNumber === "number" in such cases
Comment 3 Andrey Adaikin 2011-03-30 02:39:19 PDT 
Comment on attachment 87331 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87331&action=review

>> Source/WebCore/inspector/front-end/SourceFrame.js:188
>> +        if (this._executionLineNumber !== undefined) {
> 
> I often use typeof this._executionLineNumber === "number" in such cases

done
Comment 4 Andrey Adaikin 2011-03-30 02:42:52 PDT 
Created attachment 87489 [details]
Patch
Comment 5 Pavel Podivilov 2011-03-31 04:31:28 PDT 
Comment on attachment 87489 [details]
Patch

Clearing flags on attachment: 87489

Committed r82560: <http://trac.webkit.org/changeset/82560>
Comment 6 Pavel Podivilov 2011-03-31 04:31:37 PDT 
All reviewed patches have been landed.  Closing bug.