Bug 57208 – Fix some problems of the appearance of form validation message bubble

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Kent Tamura]

http://blog.mozilla.com/webdev/2011/03/14/html5-form-validation-on-sumo/

This page shows validation message bubbles of Firefox 4, Chrome 10, and Opera 11, and exposed some problems of the WebKit implementation.
* Unexpectedly padding value is reset
* Unexpectedly text color is not black.
* Firefox and Opera use an isosceles triangle, WebKit uses a right triangle.

[Kent Tamura]

Created attachment 87105 [details]
Patch

[Kent Tamura]

This is a workaround of http://code.google.com/p/chromium/issues/detail?id=75766

[Kent Tamura]

Created attachment 87106 [details]
Screenshot which shows how the appearance is updated

[Kent Tamura]

Created attachment 87138 [details]
Patch 2

Update ChangeLog

[Kent Tamura]

Created attachment 87140 [details]
Patch 3

[Dimitri Glazkov (Google)]

Comment on attachment 87140 [details]
Patch 3

View in context: https://bugs.webkit.org/attachment.cgi?id=87140&action=review

ok.

> Source/WebCore/ChangeLog:9
> +        because it depends on a timer.

I wonder if we can expose explicit display of validation message by exposing a hook in the layoutTestController. Capturing this in tests seems important.

[Kent Tamura]

Thank you for reviewing.

(In reply to comment #6)
> I wonder if we can expose explicit display of validation message by exposing a hook in the layoutTestController. Capturing this in tests seems important.

Yes, we should have a way to test validation message.
I'll file a bug for it.

[Kent Tamura]

(In reply to comment #7)
> Yes, we should have a way to test validation message.
> I'll file a bug for it.

Filed Bug 57290.

[Kent Tamura]

Comment on attachment 87140 [details]
Patch 3

Clearing flags on attachment: 87140

Committed r82180: <http://trac.webkit.org/changeset/82180>

[Kent Tamura]

All reviewed patches have been landed.  Closing bug.