Bug 57198 - Remove #pragma warning push and pop statements
Summary: Remove #pragma warning push and pop statements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-27 17:58 PDT by Patrick R. Gansterer
Modified: 2011-03-29 11:41 PDT (History)
1 user (show)

See Also:

Attachments
Patch (34.55 KB, patch)
2011-03-27 18:00 PDT, Patrick R. Gansterer 		aroben: review+
aroben: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2011-03-27 17:58:57 PDT 
Remove #pragma warning push and pop statements
Comment 1 Patrick R. Gansterer 2011-03-27 18:00:34 PDT 
Created attachment 87094 [details]
Patch
Comment 2 Adam Roben (:aroben) 2011-03-28 05:39:34 PDT 
Comment on attachment 87094 [details]
Patch

It would be nice to mention in the ChangeLog that we haven't needed these since we started compiling WebCore with the same compiler warnings flags as WebKit.
Comment 3 Patrick R. Gansterer 2011-03-29 11:41:03 PDT 
Committed r82294: <http://trac.webkit.org/changeset/82294>