Bug 57191 – [WIN] Use WCHAR instead of TCHAR

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Patrick R. Gansterer]

[WIN] Use WCHAR instead of TCHAR

[Patrick R. Gansterer]

Created attachment 87086 [details]
Patch

[WebKit Review Bot]

Attachment 87086 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/win/ChangeLog', u'Source/Web..." exit_code: 1

Source/WebKit/win/WebKitDLL.cpp:42:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Attachment 87086 [details] did not build on win:
Build output: http://queues.webkit.org/results/8266620

[Patrick R. Gansterer]

Created attachment 87090 [details]
Patch

[WebKit Review Bot]

Attachment 87090 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/win/ChangeLog', u'Source/Web..." exit_code: 1

Source/WebKit/win/WebKitDLL.cpp:42:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Adam Roben (:aroben)]

Comment on attachment 87090 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87090&action=review

I'm surprised that the wchar.h includes are needed.

Do you have any opinion on WCHAR vs. wchar_t?

>> Source/WebKit/win/WebKitDLL.cpp:42
>> +#include <wchar.h>
> 
> Alphabetical sorting problem.  [build/include_order] [4]

You should fix this.

[Patrick R. Gansterer]

(In reply to comment #6)
> I'm surprised that the wchar.h includes are needed.
I'm not sure if they are needed, but the w* functions are declared in wchar.h. IMHO it should be included.

> Do you have any opinion on WCHAR vs. wchar_t?
Not realy, but i think WCHAR is better since the windows xxxW functions use WCHAR for parameters too.

> >> Source/WebKit/win/WebKitDLL.cpp:42
> >> +#include <wchar.h>
> > 
> > Alphabetical sorting problem.  [build/include_order] [4]
> 
> You should fix this.
I'll do.

[Alexey Proskuryakov]

This looks somewhat strange to me. WCHAR and wchar_t are different types, why is calling functions like wcslen() on WCHAR[] ok? It's confusing at best.

[Patrick R. Gansterer]

(In reply to comment #8)
> This looks somewhat strange to me. WCHAR and wchar_t are different types, why is calling functions like wcslen() on WCHAR[] ok?
WCHAR is only a typdef to wchar_t, but most (all?) wide character windows api function use the WCHAR typedef for declaring the arguments.

> It's confusing at best.
It's windows. ;-)

[Alexey Proskuryakov]

Indeed.

[Patrick R. Gansterer]

Committed r82284: <http://trac.webkit.org/changeset/82284>