RESOLVED FIXED 57190
Add additional immediate types to allow us to distinguish the source of a JIT immediate 
https://bugs.webkit.org/show_bug.cgi?id=57190
Summary Add additional immediate types to allow us to distinguish the source of a JIT...
Oliver Hunt
Reported 2011-03-27 14:40:17 PDT
Add additional immediate types to allow us to distinguish the source of a JIT immediate
Attachments
Patch (349.78 KB, patch)
2011-03-27 14:44 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (323.31 KB, patch)
2011-03-27 15:29 PDT, Oliver Hunt 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2011-03-27 14:44:08 PDT
Created attachment 87085 [details] Patch
WebKit Review Bot
Comment 2 2011-03-27 14:46:22 PDT
Attachment 87085 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:424: Should only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/JavaScriptCore/bytecode/Instruction.h:85: _stubRoutine is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/bytecode/Instruction.h:85: _base is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/bytecode/Instruction.h:85: _chain is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/jit/JITOpcodes.cpp:55: string_failureCases2 is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/jit/JITOpcodes.cpp:60: string_failureCases3 is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:462: Should only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/JavaScriptCore/jit/JITOpcodes32_64.cpp:55: string_failureCases1 is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/jit/JITOpcodes32_64.cpp:56: string_failureCases2 is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/jit/JITOpcodes32_64.cpp:61: string_failureCases3 is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:386: Should only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 11 in 44 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 3 2011-03-27 14:56:40 PDT
Attachment 87085 [details] did not build on qt: Build output: http://queues.webkit.org/results/8266598
Build Bot
Comment 4 2011-03-27 15:08:24 PDT
Attachment 87085 [details] did not build on win: Build output: http://queues.webkit.org/results/8265591
Oliver Hunt
Comment 5 2011-03-27 15:10:33 PDT
sigh had another patch in my tree that only partially removed prior to uploading
Oliver Hunt
Comment 6 2011-03-27 15:29:29 PDT
Created attachment 87088 [details] Patch
WebKit Review Bot
Comment 7 2011-03-27 15:31:53 PDT
Attachment 87088 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:424: Should only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/JavaScriptCore/jit/JITOpcodes.cpp:55: string_failureCases2 is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/jit/JITOpcodes.cpp:60: string_failureCases3 is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:462: Should only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/JavaScriptCore/jit/JITOpcodes32_64.cpp:55: string_failureCases1 is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/jit/JITOpcodes32_64.cpp:56: string_failureCases2 is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/jit/JITOpcodes32_64.cpp:61: string_failureCases3 is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:386: Should only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 8 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 8 2011-03-27 15:49:40 PDT
Attachment 87085 [details] did not build on mac: Build output: http://queues.webkit.org/results/8271386
Zoltan Herczeg
Comment 9 2011-03-27 23:38:30 PDT
TrusterImm32 is mentioned in the ChangeLog, but I couldn't find any reference in the patch. This would be a new type? "ones that can be controlled or influenced by code we are compiling" - you mean the patchable immediate values?
Maciej Stachowiak
Comment 10 2011-03-28 03:15:27 PDT
Comment on attachment 87088 [details] Patch rs=me I did not verify that the Trusted variants are used in the right places.
Zoltan Herczeg
Comment 11 2011-03-28 03:35:27 PDT
> I did not verify that the Trusted variants are used in the right places. It seems to me that all Imm* are renamed to TrustedImm*
Zoltan Herczeg
Comment 12 2011-03-28 03:39:10 PDT
> #if !CPU(X86_64) It is a shame we don't have a 64 bit arch checker (except JSValue64, but that would be ugly).
Oliver Hunt
Comment 13 2011-03-28 10:15:51 PDT
Committed r82130: <http://trac.webkit.org/changeset/82130>
Note You need to log in before you can comment on or make changes to this bug.