Bug 57190 - Add additional immediate types to allow us to distinguish the source of a JIT immediate
Summary: Add additional immediate types to allow us to distinguish the source of a JIT...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on: 57251
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-27 14:40 PDT by Oliver Hunt
Modified: 2011-03-28 11:05 PDT (History)
4 users (show)

See Also:


Attachments
Patch (349.78 KB, patch)
2011-03-27 14:44 PDT, Oliver Hunt
no flags Details | Formatted Diff | Diff
Patch (323.31 KB, patch)
2011-03-27 15:29 PDT, Oliver Hunt
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2011-03-27 14:40:17 PDT
Add additional immediate types to allow us to distinguish the source of a JIT immediate
Comment 1 Oliver Hunt 2011-03-27 14:44:08 PDT
Created attachment 87085 [details]
Patch
Comment 2 WebKit Review Bot 2011-03-27 14:46:22 PDT
Attachment 87085 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:424:  Should only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/JavaScriptCore/bytecode/Instruction.h:85:  _stubRoutine is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/bytecode/Instruction.h:85:  _base is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/bytecode/Instruction.h:85:  _chain is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/jit/JITOpcodes.cpp:55:  string_failureCases2 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/jit/JITOpcodes.cpp:60:  string_failureCases3 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:462:  Should only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/JavaScriptCore/jit/JITOpcodes32_64.cpp:55:  string_failureCases1 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/jit/JITOpcodes32_64.cpp:56:  string_failureCases2 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/jit/JITOpcodes32_64.cpp:61:  string_failureCases3 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:386:  Should only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 11 in 44 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2011-03-27 14:56:40 PDT
Attachment 87085 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8266598
Comment 4 Build Bot 2011-03-27 15:08:24 PDT
Attachment 87085 [details] did not build on win:
Build output: http://queues.webkit.org/results/8265591
Comment 5 Oliver Hunt 2011-03-27 15:10:33 PDT
sigh had another patch in my tree that only partially removed prior to uploading
Comment 6 Oliver Hunt 2011-03-27 15:29:29 PDT
Created attachment 87088 [details]
Patch
Comment 7 WebKit Review Bot 2011-03-27 15:31:53 PDT
Attachment 87088 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:424:  Should only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/JavaScriptCore/jit/JITOpcodes.cpp:55:  string_failureCases2 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/jit/JITOpcodes.cpp:60:  string_failureCases3 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:462:  Should only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/JavaScriptCore/jit/JITOpcodes32_64.cpp:55:  string_failureCases1 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/jit/JITOpcodes32_64.cpp:56:  string_failureCases2 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/jit/JITOpcodes32_64.cpp:61:  string_failureCases3 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:386:  Should only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 8 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 WebKit Review Bot 2011-03-27 15:49:40 PDT
Attachment 87085 [details] did not build on mac:
Build output: http://queues.webkit.org/results/8271386
Comment 9 Zoltan Herczeg 2011-03-27 23:38:30 PDT
TrusterImm32 is mentioned in the ChangeLog, but I couldn't find any reference in the patch. This would be a new type? "ones that can be controlled or influenced by code we are compiling" - you mean the patchable immediate values?
Comment 10 Maciej Stachowiak 2011-03-28 03:15:27 PDT
Comment on attachment 87088 [details]
Patch

rs=me

I did not verify that the Trusted variants are used in the right places.
Comment 11 Zoltan Herczeg 2011-03-28 03:35:27 PDT
> I did not verify that the Trusted variants are used in the right places.

It seems to me that all Imm* are renamed to TrustedImm*
Comment 12 Zoltan Herczeg 2011-03-28 03:39:10 PDT
> #if !CPU(X86_64)

It is a shame we don't have a 64 bit arch checker (except JSValue64, but that would be ugly).
Comment 13 Oliver Hunt 2011-03-28 10:15:51 PDT
Committed r82130: <http://trac.webkit.org/changeset/82130>