Bug 57186 – Web Inspector: refactor ResourceTreeModel to remove poor dependencies.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Here is the list of what has been done:
- ResourceTreeModel is now event target (Object)
- There is no ResourceTreeModel -> UI dependencies
- NetworkManager -> ResourceTreeModel dependencies has been removed
- NetworkManager is no longer dealing with the resources tree, it is only responsible for network events
- ResourceTreeModel requests tree structure from the backend separately
- Cached resources tree payload is now limited to url and type (no headers involved)
- Resources tree is being rendered lazily upon request from the panel.

[Pavel Feldman]

Created attachment 87080 [details]
Patch

[Pavel Feldman]

Created attachment 87081 [details]
[PATCH] Same with more informative changelog.

[Yury Semikhatsky]

Comment on attachment 87081 [details]
[PATCH] Same with more informative changelog.

View in context: https://bugs.webkit.org/attachment.cgi?id=87081&action=review

> Source/WebCore/inspector/front-end/ResourceTreeModel.js:62
> +        WebInspector.networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.ResourceFinished, this._onResourceUpdated, this);

Please call this before getCachedResources.

> Source/WebCore/inspector/front-end/ResourceTreeModel.js:80
> +    frames: function(parentFrameId)

nuke it

> Source/WebCore/inspector/front-end/ResourceTreeModel.js:191
> +        this._resourcesByURL[resource.url] = resource;

_resourcesByURL -> _resourceByURL

[Pavel Feldman]

Committed r82106: <http://trac.webkit.org/changeset/82106>

[WebKit Review Bot]

http://trac.webkit.org/changeset/82106 might have broken Qt Linux Release