Bug 57183 - REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
Summary: REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Normal
Assignee: Andreas Kling
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-03-27 07:17 PDT by Andreas Kling
Modified: 2011-05-04 12:59 PDT (History)
6 users (show)

See Also:

Attachments
Patch (r=benjamin) (1.69 KB, patch)
2011-03-27 07:19 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-03-27 07:17:45 PDT 
The installed <QtWebKit> convenience header contains #include \<QtNetwork/QtNetwork\> which doesn't compile.
Comment 1 Andreas Kling 2011-03-27 07:19:44 PDT 
Created attachment 87069 [details]
Patch (r=benjamin)
Comment 2 Andreas Kling 2011-03-27 07:23:36 PDT 
Comment on attachment 87069 [details]
Patch (r=benjamin)

Clearing flags on attachment: 87069

Committed r82065: <http://trac.webkit.org/changeset/82065>
Comment 3 Andreas Kling 2011-03-27 07:23:44 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Csaba Osztrogonác 2011-03-27 14:03:18 PDT 
(In reply to comment #2)
> (From update of attachment 87069 [details])
> Clearing flags on attachment: 87069
> 
> Committed r82065: <http://trac.webkit.org/changeset/82065>

Unfortunately it broke the Symbian build and the Windows build, because 
Windows' cmd.exe don't like "echo #include <QtNetwork/QtNetwork> >> ..."
command. It says >> was unexpected at this time.
Comment 5 Csaba Osztrogonác 2011-03-27 14:34:16 PDT 
I have to correct my fail, it works for me on 
Windows, it seems to be a Symbian related bug. 

Jade, could you check it, please?
Comment 6 Csaba Osztrogonác 2011-03-28 07:14:22 PDT 
Windows fix landed in http://trac.webkit.org/changeset/82113