WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
57182
implement onerror events for <link rel=prefetch>
https://bugs.webkit.org/show_bug.cgi?id=57182
Summary
implement onerror events for <link rel=prefetch>
Gavin Peters
Reported
2011-03-27 07:09:15 PDT
See
Bug 50187
for the implementation of onload events for prefetch, this CL adds onerror support.
Attachments
Patch
(12.46 KB, patch)
2011-03-27 07:15 PDT
,
Gavin Peters
no flags
Details
Formatted Diff
Diff
Patch
(13.29 KB, patch)
2011-03-28 13:18 PDT
,
Gavin Peters
no flags
Details
Formatted Diff
Diff
Patch
(13.41 KB, patch)
2011-03-28 13:20 PDT
,
Gavin Peters
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Gavin Peters
Comment 1
2011-03-27 07:15:46 PDT
Created
attachment 87068
[details]
Patch
Adam Barth
Comment 2
2011-03-27 13:15:12 PDT
Comment on
attachment 87068
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=87068&action=review
> Source/WebCore/ChangeLog:22 > + * html/HTMLLinkElement.cpp: > + (WebCore::HTMLLinkElement::parseMappedAttribute): > + (WebCore::HTMLLinkElement::onloadTimerFired): > + (WebCore::HTMLLinkElement::notifyFinished): > + * loader/cache/CachedImage.cpp: > + * loader/cache/CachedImage.h: > + * loader/cache/CachedResource.cpp: > + (WebCore::CachedResource::checkNotify): > + (WebCore::CachedResource::data): > + (WebCore::CachedResource::error): > + * loader/cache/CachedResource.h: > + * loader/cache/CachedScript.cpp: > + * loader/cache/CachedScript.h:
You should explain why you're making changes to all these different files. This ChangeLog is calling out for information. Also, I feel like this patch is the result of a long discussion. It might be helpful to include some of the reasons why we're making this change in the ChangeLog. You don't need to write a whole book, but something more than just empty boilerplate is probably a good idea.
Tony Gentilcore
Comment 3
2011-03-28 09:51:17 PDT
> You should explain why you're making changes to all these different files. This ChangeLog is calling out for information. Also, I feel like this patch is the result of a long discussion. It might be helpful to include some of the reasons why we're making this change in the ChangeLog. You don't need to write a whole book, but something more than just empty boilerplate is probably a good idea.
Patch looks good to me barring Adam's comment about improving the ChangeLog. This is all specced, so you may also want to link there:
http://dev.w3.org/html5/spec/Overview.html#the-link-element
Gavin Peters
Comment 4
2011-03-28 13:18:09 PDT
Created
attachment 87187
[details]
Patch
Gavin Peters
Comment 5
2011-03-28 13:20:04 PDT
Created
attachment 87188
[details]
Patch
Gavin Peters
Comment 6
2011-03-28 13:20:25 PDT
Thanks for the reviews. I've significantly filled out the ChangeLog.
Tony Gentilcore
Comment 7
2011-03-28 13:49:30 PDT
Comment on
attachment 87188
[details]
Patch Thanks for the patch.
WebKit Commit Bot
Comment 8
2011-03-29 02:02:47 PDT
The commit-queue encountered the following flaky tests while processing
attachment 87188
[details]
: http/tests/websocket/tests/multiple-connections.html
bug 53825
(author:
abarth@webkit.org
) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 9
2011-03-29 02:06:46 PDT
Comment on
attachment 87188
[details]
Patch Clearing flags on attachment: 87188 Committed
r82217
: <
http://trac.webkit.org/changeset/82217
>
WebKit Commit Bot
Comment 10
2011-03-29 02:06:50 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug