Bug 57170 – Remove comma at end of enum. Solaris 10/Sun Studio 12 CC don't like trailing comma's on enums

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Ben Taylor]

On Solaris 10/Sun Studio 12 CC, the compiler doesn't like a trailing comma on the last element of an enum.
Most enums in the webkit code don't have a trailing comma on the last element of an enum

[Ben Taylor]

Created attachment 87052 [details]
Patch to remove trailing comma from last element of enum structures defined in webkit includes

Cleaning up webkit code to remove a trailing comma on the last element of an enum in include files.
This patch was inspired by patch 12 of 17 by Thiago Macieria from bug https://bugs.webkit.org/show_bug.cgi?id=24932

[WebKit Review Bot]

Attachment 87052 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/wtf/MessageQueue.h:44:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/platform/image-decoders/ImageDecoder.h:65:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/platform/network/ResourceRequestBase.h:44:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/platform/graphics/BitmapImage.h:164:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 4 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Ben Taylor]

(In reply to comment #2)
> Attachment 87052 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
> 
> Source/JavaScriptCore/wtf/MessageQueue.h:44:  One space before end of line comments  [whitespace/comments] [5]
> Source/WebCore/platform/image-decoders/ImageDecoder.h:65:  One space before end of line comments  [whitespace/comments] [5]
> Source/WebCore/platform/network/ResourceRequestBase.h:44:  One space before end of line comments  [whitespace/comments] [5]
> Source/WebCore/platform/graphics/BitmapImage.h:164:  One space before end of line comments  [whitespace/comments] [5]
> Total errors found: 4 in 14 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

(In reply to comment #2)
> Attachment 87052 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
> 
> Source/JavaScriptCore/wtf/MessageQueue.h:44:  One space before end of line comments  [whitespace/comments] [5]
> Source/WebCore/platform/image-decoders/ImageDecoder.h:65:  One space before end of line comments  [whitespace/comments] [5]
> Source/WebCore/platform/network/ResourceRequestBase.h:44:  One space before end of line comments  [whitespace/comments] [5]
> Source/WebCore/platform/graphics/BitmapImage.h:164:  One space before end of line comments  [whitespace/comments] [5]
> Total errors found: 4 in 14 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

These errors are surely false positives.  Replacing a trailing comma from the last element of a enum with a space, which also has a trailing C++ style comment on the same line, should not generate a style error.  Bug against check-webkit-style reported.

[Ben Taylor]

(In reply to comment #3)
> (In reply to comment #2)
> > Attachment 87052 [details] [details] did not pass style-queue:
> > 
> > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
> > 
> > Source/JavaScriptCore/wtf/MessageQueue.h:44:  One space before end of line comments  [whitespace/comments] [5]
> > Source/WebCore/platform/image-decoders/ImageDecoder.h:65:  One space before end of line comments  [whitespace/comments] [5]
> > Source/WebCore/platform/network/ResourceRequestBase.h:44:  One space before end of line comments  [whitespace/comments] [5]
> > Source/WebCore/platform/graphics/BitmapImage.h:164:  One space before end of line comments  [whitespace/comments] [5]
> > Total errors found: 4 in 14 files
> > 
> > 
> > If any of these errors are false positives, please file a bug against check-webkit-style.
> 
> These errors are surely false positives.  Replacing a trailing comma from the last element of a enum with a space, which also has a trailing C++ style comment on the same line, should not generate a style error.  Bug against check-webkit-style reported.

bug against check-webkit-style at https://bugs.webkit.org/show_bug.cgi?id=57171

[WebKit Commit Bot]

Comment on attachment 87052 [details]
Patch to remove trailing comma from last element of enum structures defined in webkit includes

Clearing flags on attachment: 87052

Committed r82067: <http://trac.webkit.org/changeset/82067>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.