Bug 5717 - REGRESSION: [WebCoreBridge _visiblePositionForPoint:(0,x)] crashes
Summary: REGRESSION: [WebCoreBridge _visiblePositionForPoint:(0,x)] crashes
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Major
Assignee: Justin Garcia
Depends on:
Blocks: 5230
  Show dependency treegraph
Reported: 2005-11-12 07:39 PST by Alexey Proskuryakov
Modified: 2005-11-21 11:04 PST (History)
0 users

See Also:

naive fix (738 bytes, patch)
2005-11-12 07:41 PST, Alexey Proskuryakov
justin.garcia: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2005-11-12 07:39:24 PST
_visiblePositionForPoint lacks a check for the case when renderer->layer()->hitTest() doesn't find any 

This causes a crash in "run-webkit-tests editing/input/text-input-controller.html" with a fix to bug 5230 
being applied. Used to work fine before - apparently, some recent checkin has changed the behavior of 
Comment 1 Alexey Proskuryakov 2005-11-12 07:41:25 PST
Created attachment 4674 [details]
naive fix

I couldn't find the reason why the behavior has changed - but the check for nil
seems necessary here nonetheless.
Comment 2 Justin Garcia 2005-11-14 14:19:51 PST
Comment on attachment 4674 [details]
naive fix

As long as it's correct for hitTest to not find a node in this case, r=me.
Comment 3 Justin Garcia 2005-11-15 11:14:57 PST