Bug 57156 - RenderMedia should obey the view's flattening bit.
Summary: RenderMedia should obey the view's flattening bit.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-03-26 11:31 PDT by Jer Noble
Modified: 2011-03-26 17:32 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.50 KB, patch)
2011-03-26 12:08 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (1.50 KB, patch)
2011-03-26 12:32 PDT, Jer Noble
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2011-03-26 11:31:13 PDT
RenderMedia currently does not paint when the RenderView is drawing in flattening mode.
Comment 1 Jer Noble 2011-03-26 11:31:26 PDT
<rdar://problem/9028914>
Comment 2 Jer Noble 2011-03-26 11:35:54 PDT
Sorry, the FrameView (not the RenderView).
Comment 3 Jer Noble 2011-03-26 12:08:10 PDT
Created attachment 87034 [details]
Patch
Comment 4 mitz 2011-03-26 12:13:08 PDT
Comment on attachment 87034 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87034&action=review

> Source/WebCore/rendering/RenderVideo.cpp:205
> +    else if (document()->view() && document()->view()->paintBehavior() == PaintBehaviorFlattenCompositingLayers)

paintBehavior() is a bitmask, so you should check for (paintBehavior() & PaintBehaviorFlattenCompositingLayers)
Comment 5 Jer Noble 2011-03-26 12:18:19 PDT
(In reply to comment #4)
> (From update of attachment 87034 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=87034&action=review
> 
> > Source/WebCore/rendering/RenderVideo.cpp:205
> > +    else if (document()->view() && document()->view()->paintBehavior() == PaintBehaviorFlattenCompositingLayers)
> 
> paintBehavior() is a bitmask, so you should check for (paintBehavior() & PaintBehaviorFlattenCompositingLayers)

Good point.  Changed.
Comment 6 mitz 2011-03-26 12:20:14 PDT
Comment on attachment 87034 [details]
Patch

r+ with the change
Comment 7 Jer Noble 2011-03-26 12:32:15 PDT
Created attachment 87038 [details]
Patch
Comment 8 Jer Noble 2011-03-26 12:33:17 PDT
(In reply to comment #6)
> (From update of attachment 87034 [details])
> r+ with the change

Whoops, uploaded a new patch.  Undoing. :)
Comment 9 Jer Noble 2011-03-26 12:34:02 PDT
TIL: obseleting a patch clears its flags.  Would you mind r+'ing the new one?
Comment 10 Jer Noble 2011-03-26 16:22:28 PDT
Comment on attachment 87038 [details]
Patch

Clearing c+; preparing to commit manually.
Comment 11 Jer Noble 2011-03-26 16:47:27 PDT
Committed r82051: <http://trac.webkit.org/changeset/82051>
Comment 12 WebKit Commit Bot 2011-03-26 17:32:04 PDT
The commit-queue encountered the following flaky tests while processing attachment 87038 [details]:

http/tests/websocket/tests/httponly-cookie.pl bug 54097 (author: abarth@webkit.org)
The commit-queue is continuing to process your patch.