Bug 57152 – Add PlatformCertificateInfo::PlatformCertificateInfo(PCCERT_CONTEXT) constructor on Windows

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Jeff Miller]

We're going to need to create a PlatformCertificateInfo with a single certificate on Windows to support client certificates.  Also, stop relying on the fact that the Win32 API CertDuplicateCertificateContext() currently returns the same PCCERT_CONTEXT that you pass to it, since that may change in the future.

[Jeff Miller]

Created attachment 87026 [details]
Patch

[Steve Falkenburg]

Comment on attachment 87026 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87026&action=review

> Source/WebKit2/Shared/win/PlatformCertificateInfo.cpp:78
> +#if PLATFORM(CG)

PLATFORM(CG) seems weird here, but I see it elsewhere already. Did you consider USE(CFNETWORK) instead?

[Jeff Miller]

(In reply to comment #2)
> (From update of attachment 87026 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=87026&action=review
> 
> > Source/WebKit2/Shared/win/PlatformCertificateInfo.cpp:78
> > +#if PLATFORM(CG)
> 
> PLATFORM(CG) seems weird here, but I see it elsewhere already. Did you consider USE(CFNETWORK) instead?

Thanks for pointing that out.  It looks like we use PLATFORM(CG) in the other constructor because it relies on WebKitSystemInterface.  Since the constructor I added just uses CertDuplicateCertificateContext(), a Win32 API, it should work fine on all Windows platforms.  I'll remove the test altogether.

[Jeff Miller]

Committed r82049: <http://trac.webkit.org/changeset/82049>