in Source/WebCore/bindings/js/JSJavaScriptCallFrameCustom.cpp on Solaris 10 with Sun Studio 12 CC, the compiler emits this error Error: Ambiguous "?:" expression, second operand of type "JSC::JSObject*" and third operand of type "JSC::JSValuePtr" can be converted to one another. This is from patch 14 of 17 by Thiago Macieria from bug https://bugs.webkit.org/show_bug.cgi?id=24932
Created attachment 87025 [details] Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler This is a update from patch 14 of 17 in bug https://bugs.webkit.org/show_bug.cgi?id=24932 done by Thiago Macieria. Compiles correctly on Solaris 10/Sun Studio 12 CC on qt-4.7.2 with webkit enabled. Patch is against webkit head.
Comment on attachment 87025 [details] Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler r=me, i'm surprised this doesn't fail on other platforms as gcc, et all all seem finicky about ?: operator. Thanks for the patch.
Comment on attachment 87025 [details] Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler What's the ambiguity?
I see. OK.
Comment on attachment 87025 [details] Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler Clearing flags on attachment: 87025 Committed r82060: <http://trac.webkit.org/changeset/82060>
All reviewed patches have been landed. Closing bug.