Bug 57108 - [Qt][Symbian] Fix Api test failure -- microFocusCoordinates
Summary: [Qt][Symbian] Fix Api test failure -- microFocusCoordinates
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: S60 Hardware All
: P2 Normal
Assignee: Yi Shen
URL:
Keywords:
Depends on:
Blocks: 50925
  Show dependency tree / graph
 
Reported: 2011-03-25 11:28 PDT by Yi Shen
Modified: 2011-05-17 06:16 PDT (History)
5 users (show)

See Also:

Attachments
first try (2.47 KB, patch)
2011-03-25 11:39 PDT, Yi Shen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yi Shen 2011-03-25 11:28:57 PDT 
The tst_QWebView::microFocusCoordinates failed because its test page content is incorrect -- canvas tag is not self-closing tag. See the problem code below,

      page->mainFrame()->setHtml("<html><body>" \
        "<input type='text' id='input1' style='font--family: serif' value='' maxlength='20'/><br>" \
        "<canvas id='canvas1' width='500' height='500'/>" \
        "<input type='password'/><br>" \
        "<canvas id='canvas2' width='500' height='500'/>" \
        "</body></html>");

Will provide a patch soon.
Comment 1 Yi Shen 2011-03-25 11:30:03 PDT 
The same problem for tst_QGraphicsWebView::microFocusCoordinates()
Comment 2 Yi Shen 2011-03-25 11:39:17 PDT 
Created attachment 86965 [details]
first try
Comment 3 Eric Seidel (no email) 2011-03-27 01:11:21 PDT 
<canvas isn't self closing?  I forget these things.
Comment 4 Andreas Kling 2011-03-27 04:00:20 PDT 
Comment on attachment 86965 [details]
first try

Good catch. :3
Comment 5 WebKit Commit Bot 2011-03-27 11:23:32 PDT 
The commit-queue encountered the following flaky tests while processing attachment 86965 [details]:

http/tests/navigation/forward-and-cancel.html bug 57187
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2011-03-27 11:26:31 PDT 
Comment on attachment 86965 [details]
first try

Clearing flags on attachment: 86965

Committed r82074: <http://trac.webkit.org/changeset/82074>
Comment 7 WebKit Commit Bot 2011-03-27 11:26:35 PDT 
All reviewed patches have been landed.  Closing bug.