Bug 57102 - [Qt] Get rid of the invalid string conversion with ::fromAscii()
Summary: [Qt] Get rid of the invalid string conversion with ::fromAscii()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords: EasyFix, Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-03-25 07:07 PDT by Benjamin Poulain
Modified: 2011-03-25 09:47 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.53 KB, patch)
2011-03-25 07:37 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2011-03-25 07:07:20 PDT 
QString/QChar::fromAscii() is almost never correct inside a library. This call use the default codec, not the  ascii one.
Comment 1 Benjamin Poulain 2011-03-25 07:37:28 PDT 
Created attachment 86936 [details]
Patch

Uploaded manually, webkit-patch exploded in one thousand sparkling pieces for some reason.
Comment 2 Andreas Kling 2011-03-25 07:41:36 PDT 
Comment on attachment 86936 [details]
Patch

em=r
Comment 3 WebKit Commit Bot 2011-03-25 08:02:53 PDT 
Comment on attachment 86936 [details]
Patch

Clearing flags on attachment: 86936

Committed r81961: <http://trac.webkit.org/changeset/81961>
Comment 4 WebKit Commit Bot 2011-03-25 08:02:58 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2011-03-25 09:47:59 PDT 
http://trac.webkit.org/changeset/81961 might have broken Windows 7 Release (Tests)
The following tests are not passing:
http/tests/websocket/tests/frame-length-skip.html