Bug 57092 - [Qt] QNetworkReplyHandler refactoring: some adjustments
Summary: [Qt] QNetworkReplyHandler refactoring: some adjustments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Luiz Agostini
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2011-03-25 01:39 PDT by Luiz Agostini
Modified: 2011-05-03 11:01 PDT (History)
7 users (show)

See Also:


Attachments
patch (8.21 KB, patch)
2011-03-25 01:44 PDT, Luiz Agostini
no flags Details | Formatted Diff | Diff
patch (10.09 KB, patch)
2011-04-13 21:03 PDT, Luiz Agostini
kling: review-
Details | Formatted Diff | Diff
patch (9.85 KB, patch)
2011-04-15 11:52 PDT, Luiz Agostini
kling: review+
kling: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Luiz Agostini 2011-03-25 01:39:53 PDT
further simplification is possible due to the invariants created by previous patches.
Comment 1 Luiz Agostini 2011-03-25 01:44:06 PDT
Created attachment 86910 [details]
patch

please review
Comment 2 Jocelyn Turcotte 2011-03-28 07:37:43 PDT
I'm no official reviewer but this looks good to me.
Comment 3 Luiz Agostini 2011-04-13 21:03:11 PDT
Created attachment 89525 [details]
patch
Comment 4 Andreas Kling 2011-04-14 09:37:28 PDT
Comment on attachment 89525 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89525&action=review

> Source/WebCore/ChangeLog:12
> +        - Ignoring status code 404 because application cache depends on it.

This should be in a separate patch with a test. :)
Comment 5 Andreas Kling 2011-04-14 09:37:43 PDT
Comment on attachment 89525 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89525&action=review

> Source/WebCore/ChangeLog:12
> +        - Ignoring status code 404 because application cache depends on it.

This should be in a separate patch with a test. :)
Comment 6 Luiz Agostini 2011-04-15 11:52:53 PDT
Created attachment 89822 [details]
patch
Comment 7 Andreas Kling 2011-04-15 12:11:07 PDT
Comment on attachment 89822 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89822&action=review

Another nice cleanup. :)

r=me with some minor fixes before landing:

> Source/WebCore/platform/network/qt/QNetworkReplyHandler.h:78
> +    bool redirected() const { return m_redirectionTargetUrl.isValid(); }

wasRedirected() would read nicer IMO.

> Source/WebCore/platform/network/qt/QNetworkReplyHandler.h:97
> +    int m_statusCode;

This is not used anywhere, should be removed.
Comment 8 Luiz Agostini 2011-05-03 11:01:03 PDT
landed. http://trac.webkit.org/changeset/84018