Bug 57091 - <keygen> does not support autofocus
Summary: <keygen> does not support autofocus
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-25 00:28 PDT by Dominic Cooney
Modified: 2011-03-25 01:18 PDT (History)
1 user (show)

See Also:

Attachments
Patch (3.50 KB, patch)
2011-03-25 00:31 PDT, Dominic Cooney 		no flags Details | Formatted Diff | Diff
Patch (3.47 KB, patch)
2011-03-25 00:52 PDT, Dominic Cooney 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominic Cooney 2011-03-25 00:28:02 PDT 
The keygen element does not support the autofocus attribute. When a keygen element has the autofocus attribute, it does not automatically get focus.
Comment 1 Dominic Cooney 2011-03-25 00:31:12 PDT 
Created attachment 86905 [details]
Patch
Comment 2 Kent Tamura 2011-03-25 00:44:06 PDT 
Comment on attachment 86905 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86905&action=review

> LayoutTests/fast/forms/autofocus-keygen.html:16
> +    shouldBe('focusedElement', 'document.querySelector("keygen")');

I think document.activeElement works instead of focusedElement.

> LayoutTests/fast/forms/autofocus-keygen.html:23
> +successfullyParsed = true;
> +</script>
> +</head>
> +<body onload="onLoad();">

This doesn't follow usual style of our layout tests.

Please do:
 - remove layoutTestController.dumpAsText() in the second <script>
 - add window.jsTestisAsync = true in the second <script>
 - add finishJSTest() at the bottom of onLoad()
 - add <script> for js/resources/js-test-post.js at the bottom of <body>
Comment 3 Dominic Cooney 2011-03-25 00:52:50 PDT 
Created attachment 86907 [details]
Patch
Comment 4 Kent Tamura 2011-03-25 00:55:10 PDT 
Comment on attachment 86907 [details]
Patch

ok
Comment 5 WebKit Commit Bot 2011-03-25 01:18:50 PDT 
Comment on attachment 86907 [details]
Patch

Clearing flags on attachment: 86907

Committed r81947: <http://trac.webkit.org/changeset/81947>
Comment 6 WebKit Commit Bot 2011-03-25 01:18:55 PDT 
All reviewed patches have been landed.  Closing bug.