Bug 57083 - [Qt] QNetworkReplyHandler refactoring: redirect signal
Summary: [Qt] QNetworkReplyHandler refactoring: redirect signal
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Luiz Agostini
URL:
Keywords: Qt
Depends on: 57075
Blocks:
  Show dependency tree / graph
 
Reported: 2011-03-24 23:13 PDT by Luiz Agostini
Modified: 2013-02-22 02:54 PST (History)
7 users (show)

See Also:

Attachments
patch (12.23 KB, patch)
2011-03-24 23:25 PDT, Luiz Agostini 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luiz Agostini 2011-03-24 23:13:01 PDT 
Creating a new signal name 'redirected' to be sent by QNetworkReplyWrapper to QNetworkReplyHandler.

The rule for this signal is that if it is sent then no other signal will be sent. Then redirections may be handled completely in its own. The other methods of QNetworkReplyHandler should not take care of redirections and the flag m_redirected is no longer needed.
Comment 1 Luiz Agostini 2011-03-24 23:25:01 PDT 
Created attachment 86894 [details]
patch

please review.
Comment 2 Jocelyn Turcotte 2011-03-28 07:37:35 PDT 
- qDebug could be removed in this patch instead of removing it in the cleanup patch.
- redirected() and redirect() are doing repeated logic and have confusing name.
It would be nice to merge them or to give them more defining names and purpose.