Bug 57077 – SVG <use> element performance improvement

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Leo Yang]

SVG <use> element expands nesting <use> and <symbol> elements in an inefficient way. After it expands an <use> or a <symbol> element it will restart expanding from the shadow tree root. This leads about 160 millions of calls to expandUseElementInShadowTree or expandSymbolElementInShadowTree for a single shadow tree which is illustrated by the *URL* field of this bug. But the effective calls, which will really expand <use> or <symbol> elements, are about 5200; others are passing-by calls which are recursively down to the children.

Patch is coming soon...

[Leo Yang]

Created attachment 86896 [details]
Patch

[Nikolas Zimmermann]

Comment on attachment 86896 [details]
Patch

This looks wonderful! Great work Leo, r=me. Are you saying we can render Sierpinski_carpet_6 now??

[Dirk Schulze]

(In reply to comment #2)
> (From update of attachment 86896 [details])
> This looks wonderful! Great work Leo, r=me. Are you saying we can render Sierpinski_carpet_6 now??

Please add the test as a manual perf test to the svg directory. IIRC aroben created a new dir. You can do it as a followup

[Leo Yang]

(In reply to comment #2)
> (From update of attachment 86896 [details])
> This looks wonderful! Great work Leo, r=me. Are you saying we can render Sierpinski_carpet_6 now??

We can render it now. But seems render it not same as FireFox, I will look at the rendering issue.

[Leo Yang]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 86896 [details] [details])
> > This looks wonderful! Great work Leo, r=me. Are you saying we can render Sierpinski_carpet_6 now??
> 
> Please add the test as a manual perf test to the svg directory. IIRC aroben created a new dir. You can do it as a followup

ok, will upload it soon.

[Leo Yang]

Created attachment 86909 [details]
Patch - manual test case

[Nikolas Zimmermann]

Comment on attachment 86909 [details]
Patch - manual test case

r=me. Keen to test the file locally :-)

[Nikolas Zimmermann]

Comment on attachment 86909 [details]
Patch - manual test case

Revoking r+ after discussion with Dirk. The directory is wrong. Source/WebCore/manual-tests/svg-performance doesn't exist.
I think a new directory in PerformanceTests might be better.
Maybe we should ask Adam before...

[WebKit Commit Bot]

Comment on attachment 86896 [details]
Patch

Clearing flags on attachment: 86896

Committed r81950: <http://trac.webkit.org/changeset/81950>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Leo Yang]

Created attachment 86914 [details]
Patch - manual test case revised

[Dirk Schulze]

Comment on attachment 86914 [details]
Patch - manual test case revised

Ah sorry, you forgot to modify the Changelog in PerformanceTest/

[Dirk Schulze]

Comment on attachment 86914 [details]
Patch - manual test case revised

My fault. Thought you modified the wrong ChangeLog. Sorry. :-(

[Leo Yang]

Reopen so cq can land the review test case

[WebKit Commit Bot]

Comment on attachment 86914 [details]
Patch - manual test case revised

Clearing flags on attachment: 86914

Committed r81960: <http://trac.webkit.org/changeset/81960>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/81960 might have broken Windows 7 Release (Tests)
The following tests are not passing:
http/tests/websocket/tests/frame-length-skip.html