Bug 57074 - REGRESSION: 10 MB increase in CachedScripts on Membuster
Summary: REGRESSION: 10 MB increase in CachedScripts on Membuster
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-03-24 19:58 PDT by Stephanie Lewis
Modified: 2011-03-25 14:23 PDT (History)
3 users (show)

See Also:


Attachments
patch (1.66 KB, patch)
2011-03-24 19:59 PDT, Stephanie Lewis
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephanie Lewis 2011-03-24 19:58:47 PDT
REGRESSION: 10 MB increase in CachedScripts on Membuster.   Regression caused by http://trac.webkit.org/projects/webkit/changeset/78297.  
Fix by adding back removed call to destroy decoded data.

<rdar://problem/9146716> REGRESSION: ~10 MB increase in memory under CachedScripts
Comment 1 Stephanie Lewis 2011-03-24 19:59:18 PDT
Created attachment 86873 [details]
patch
Comment 2 Geoffrey Garen 2011-03-24 20:41:15 PDT
Comment on attachment 86873 [details]
patch

r=me, but, as discussed by email, please talk to Michael and make sure you're on the same page here -- he measured r78297 as a membuster improvement!
Comment 3 Michael Saboff 2011-03-25 10:28:05 PDT
Stephanie's change in the patch focuses on the during test memory usage while my earlier change addressed retained CachedScript data after MemBuster has finished.  From her email comment:

Michael was testing the end of the test whereas I am looking at the high water mark.  I also saw his change as a win for the end of the test.

Michaels change was in response to the bug I filed that said that data from JSC parser was hanging around after all the windows had been closed.  Michaels change fixed this by adding a timer to destroy CachedScript decoded data and as part of that to clear the SourceProviderCache.  It was a win for the end of membuster.  In adding the timer he removed the optimization to immediately throw away decoded data from CachedScripts regressing the high water mark.  Since closing the window would trigger his timer it wouldn't have been obvious from the end of the test that the high water mark had increased.

I agree with this change.
Comment 4 Stephanie Lewis 2011-03-25 14:23:40 PDT
committed http://trac.webkit.org/projects/webkit/changeset/81991