Bug 57064 - WebFrame forward declares WebURLLoaderOptions as a class when it's a struct.
Summary: WebFrame forward declares WebURLLoaderOptions as a class when it's a struct.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-24 16:39 PDT by Bill Budge
Modified: 2011-04-06 10:38 PDT (History)
4 users (show)

See Also:

Attachments
Proposed Patch (1.08 KB, text/plain)
2011-03-24 16:41 PDT, Bill Budge 		no flags Details
Proposed Patch (1.27 KB, patch)
2011-03-24 16:49 PDT, Bill Budge 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bill Budge 2011-03-24 16:39:32 PDT 
This causes a build error in Chromium code.
Comment 1 Bill Budge 2011-03-24 16:41:30 PDT 
Created attachment 86859 [details]
Proposed Patch
Comment 2 Bill Budge 2011-03-24 16:44:38 PDT 
Comment on attachment 86859 [details]
Proposed Patch

Gah. I got confused by changes on my checkout. Never mind.
Comment 3 Bill Budge 2011-03-24 16:47:52 PDT 
Comment on attachment 86859 [details]
Proposed Patch

On second thought, this is needed.
Comment 4 Bill Budge 2011-03-24 16:49:32 PDT 
Created attachment 86860 [details]
Proposed Patch

On fourth thought, better make it right.
Comment 5 Eric Seidel (no email) 2011-03-24 17:01:28 PDT 
Comment on attachment 86860 [details]
Proposed Patch

OK.
Comment 6 Eric Seidel (no email) 2011-03-24 17:02:22 PDT 
It seems like we should catch this sort of thing with check-webkit-style.  Probably by just deprecating "struct" from WebKit code.  So rarely does  a "struct" really want to be a struct and not just a class Foo { public:
Comment 7 Dmitry Titov 2011-03-24 18:10:46 PDT 
Comment on attachment 86860 [details]
Proposed Patch

Clearing flags on attachment: 86860

Committed r81926: <http://trac.webkit.org/changeset/81926>
Comment 8 Dmitry Titov 2011-03-24 18:10:51 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Eric Seidel (no email) 2011-04-06 10:38:31 PDT 
Comment on attachment 86859 [details]
Proposed Patch

Cleared review? from obsolete attachment 86859 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).