Bug 57062 - [chromium] Remove deprecated overload of openFileSystem for workers
Summary: [chromium] Remove deprecated overload of openFileSystem for workers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Adam Klein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-24 15:52 PDT by Adam Klein
Modified: 2011-03-25 12:29 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.73 KB, patch)
2011-03-24 15:53 PDT, Adam Klein 		no flags Details | Formatted Diff | Diff
Patch (1.32 KB, patch)
2011-03-24 16:41 PDT, Adam Klein 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Klein 2011-03-24 15:52:32 PDT 
[chromium] Remove deprecated overload of openFileSystem for workers
Comment 1 Adam Klein 2011-03-24 15:53:05 PDT 
Created attachment 86850 [details]
Patch
Comment 2 Adam Klein 2011-03-24 16:41:05 PDT 
Created attachment 86858 [details]
Patch
Comment 3 Adam Klein 2011-03-24 18:06:12 PDT 
+levin, who's reviewed all my recent changes related to workers and filesystems.
Comment 4 David Levin 2011-03-24 18:21:19 PDT 
I wonder if we need to roll DEPS for this change to the version of chromium that no longer uses it.  

WebKit/chromium/DEPS
Comment 5 Adam Klein 2011-03-25 09:28:37 PDT 
I'm about to submit the Chromium side of this change (http://codereview.chromium.org/6736012/), but this method is called only on the WebKit side, so the two changes can safely be landed in any order.  Landing this one first simply means that the Chromium code will no longer be overriding this method, but providing its own of the same name.

This happens to be simpler than usual in this case because the method has a default implementation in WebKit.  Otherwise, ordering would be important.

I've tested that this works as expected by building with "build-webkit --chromium".
Comment 6 WebKit Commit Bot 2011-03-25 11:26:32 PDT 
Comment on attachment 86858 [details]
Patch

Clearing flags on attachment: 86858

Committed r81972: <http://trac.webkit.org/changeset/81972>
Comment 7 WebKit Commit Bot 2011-03-25 11:26:36 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 WebKit Commit Bot 2011-03-25 12:29:43 PDT 
The commit-queue encountered the following flaky tests while processing attachment 86858 [details]:

fast/workers/storage/use-same-database-in-page-and-workers.html bug 50995 (author: dumi@chromium.org)
The commit-queue is continuing to process your patch.