http/tests/websocket/tests/workers/worker-handshake-challenge-randomness.html crashed once on Windows XP Debug (Tests). See the URL for the crash log. It looks like the same CFSocket is being modified on multiple threads concurrently.
Seems related to bug 56625.
<rdar://problem/9183661>
+ ukai due to websocket issue.
This test is now being skipped (see bug 55579).
This is a fairly obvious object lifetime bug, and it's probably reasonably easy to fix, but I couldn't figure it out in the time I had for this so far.
(In reply to comment #5) > This is a fairly obvious object lifetime bug, and it's probably reasonably easy to fix, but I couldn't figure it out in the time I had for this so far. I don't know much about CoreFoundation, but it seems it schedules read/write stream on loaderRunLoop() on PLATFORM(WIN) in scheduleStreams(), but it tries to unschedule stream on CFRunLoopGetCurrent(), which is used in scheduling stream on other platform than WIN. So, I think this can be fixed to use loaderRunLoop() on PLATFORM(WIN) in platformClose(). I'll create a patch.
Created attachment 94029 [details] Patch
Created attachment 94030 [details] Patch
Comment on attachment 94030 [details] Patch Looks good to me. (I'm not a reviewer, so I can't r+ this.)
Comment on attachment 94030 [details] Patch Heh, this is a good catch! I'm not sure if it takes care of the whole problem - do you have a Windows setup to run the tests?
Comment on attachment 94030 [details] Patch I'm going to say r+, since this is clearly an improvement, but the bug may need to remain open until someone can test on Windows, and until the skipped tests are re-enabled. See also: <http://trac.webkit.org/changeset/81111> (where I unsuccessfully tried to fix the crashes).
Committed r86822: <http://trac.webkit.org/changeset/86822>
I just landed the patch (id=94030). I don't have windows, so please someone test whether it fixes problems. I leave this bug open for now.
This code was landed five years ago. I think we can close it.