Bug 57047 - MediaPlayerPrivateQuickTimeVisualContext should use the Application Cache during load.
Summary: MediaPlayerPrivateQuickTimeVisualContext should use the Application Cache dur...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on: 53784
Blocks:
  Show dependency tree / graph
 
Reported: 2011-03-24 13:11 PDT by Jer Noble
Modified: 2011-03-25 18:51 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.40 KB, patch)
2011-03-24 13:52 PDT, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2011-03-24 13:11:51 PDT 
MediaPlayerPrivateQuickTimeVisualContext should use the Application Cache during load.
Comment 1 Jer Noble 2011-03-24 13:52:58 PDT 
Created attachment 86825 [details]
Patch
Comment 2 Eric Carlson 2011-03-24 14:19:54 PDT 
Comment on attachment 86825 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86825&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests.

You should probably say why no new tests are needed.

> Source/WebCore/ChangeLog:10
> +        When loading a URL, checkk osee if the Appplication Cache has a version of that URL

Typo: "checkk osee" -> "check to see"
Comment 3 Build Bot 2011-03-24 14:48:31 PDT 
Attachment 86825 [details] did not build on win:
Build output: http://queues.webkit.org/results/8240267
Comment 4 Jer Noble 2011-03-25 17:46:10 PDT 
<rdar://problem/9191677>
Comment 5 Jer Noble 2011-03-25 17:51:38 PDT 
Committed r82014: <http://trac.webkit.org/changeset/82014>
Comment 6 WebKit Review Bot 2011-03-25 18:51:42 PDT 
http://trac.webkit.org/changeset/82014 might have broken Windows 7 Release (Tests)
The following tests are not passing:
fast/text/justify-ideograph-leading-expansion.html