Bug 57041 - [fileapi] Make FileError and FileException accessible from WorkerContext
Summary: [fileapi] Make FileError and FileException accessible from WorkerContext
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Klein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-24 12:17 PDT by Adam Klein
Modified: 2011-03-24 16:16 PDT (History)
7 users (show)

See Also:

Attachments
Patch (4.21 KB, patch)
2011-03-24 12:18 PDT, Adam Klein 		no flags Details | Formatted Diff | Diff
Indentation fixed (3.96 KB, patch)
2011-03-24 13:19 PDT, Adam Klein 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Klein 2011-03-24 12:17:25 PDT 
[fileapi] Make FileError and FileException accessible from WorkerContext
Comment 1 Adam Klein 2011-03-24 12:18:31 PDT 
Created attachment 86808 [details]
Patch
Comment 2 David Levin 2011-03-24 13:10:19 PDT 
Comment on attachment 86808 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86808&action=review

r+ but cq- due to indenting issue.

> Source/WebCore/workers/WorkerContext.idl:116
> +        attribute [EnabledAtRuntime=FileSystem] FlagsConstructor Flags;

The indentation is on purpose and follows the format done typically in spec iirc.

Hint look at where attribute would be if readonly preceded it.

> Source/WebCore/workers/WorkerContext.idl:117
> +        attribute [EnabledAtRuntime=FileSystem] FileErrorConstructor FileError;

Ok, FileError.idl has NoStaticTables attribute.

> Source/WebCore/workers/WorkerContext.idl:118
> +        attribute [EnabledAtRuntime=FileSystem] FileExceptionConstructor FileException;

Ok, FileException.idl has NoStaticTables attribute.
Comment 3 Adam Klein 2011-03-24 13:19:10 PDT 
Created attachment 86820 [details]
Indentation fixed
Comment 4 WebKit Commit Bot 2011-03-24 15:13:29 PDT 
Comment on attachment 86820 [details]
Indentation fixed

Clearing flags on attachment: 86820

Committed r81906: <http://trac.webkit.org/changeset/81906>
Comment 5 WebKit Commit Bot 2011-03-24 15:13:34 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2011-03-24 16:16:26 PDT 
http://trac.webkit.org/changeset/81906 might have broken Leopard Intel Debug (Tests)