RESOLVED FIXED 57038
Web Inspector: re-implement dom breakpoints. 
https://bugs.webkit.org/show_bug.cgi?id=57038
Summary Web Inspector: re-implement dom breakpoints.
Pavel Podivilov
Reported 2011-03-24 11:04:05 PDT
Web Inspector: re-implement dom breakpoints. Move all logic related to dom breakpoints to DOMBreakpointsSidebarPane.js file.
Attachments
Patch. (58.55 KB, patch)
2011-03-24 11:04 PDT, Pavel Podivilov 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2011-03-24 11:04:39 PDT
Created attachment 86800 [details] Patch.
Pavel Feldman
Comment 2 2011-03-24 11:06:57 PDT
Comment on attachment 86800 [details] Patch. Why is this necessary? Could you split it into a number of changes or send more compact move diffs? Otherwise it is hard to follow.
Pavel Podivilov
Comment 3 2011-03-25 02:45:41 PDT
(In reply to comment #2) > (From update of attachment 86800 [details]) > Why is this necessary? Could you split it into a number of changes or send more compact move diffs? Otherwise it is hard to follow. It's the final part of browser breakpoints refactoring, half of this patch is large blocks or removed dead code. DOMBreakpointsSidebarPane is implemented from scratch (the code is mostly new). Splitting this into a number of changes which don't introduce regressions will be a real pain.
Pavel Feldman
Comment 4 2011-04-14 06:21:02 PDT
Comment on attachment 86800 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=86800&action=review > Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js:54 > +WebInspector.DOMBreakpointsSidebarPane.instance = function() We don't use singletons elsewhere. Why is this necessary? > Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js:66 > + var fragmentIndex = url.indexOf("#"); I think we have this somewhere else as well. Should we move this to the utilities.js?
Pavel Podivilov
Comment 5 2011-04-14 09:19:15 PDT
Committed r83864: <http://trac.webkit.org/changeset/83864>
Pavel Podivilov
Comment 6 2011-04-14 09:21:41 PDT
(In reply to comment #4) > (From update of attachment 86800 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=86800&action=review > > > Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js:54 > > +WebInspector.DOMBreakpointsSidebarPane.instance = function() > > We don't use singletons elsewhere. Why is this necessary? > > > Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js:66 > > + var fragmentIndex = url.indexOf("#"); > > I think we have this somewhere else as well. Should we move this to the utilities.js? Done.
Note You need to log in before you can comment on or make changes to this bug.