Bug 57036 – Web Inspector: fix call frames positions for formatted scripts.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Podivilov]

Web Inspector: fix call frames positions for formatted scripts.

Introduce PresentationCallFrame class that encapsulates source mapping details from UI components.

[Pavel Podivilov]

Created attachment 86795 [details]
Patch.

[Pavel Podivilov]

Created attachment 87142 [details]
Rebase.

[Yury Semikhatsky]

Comment on attachment 86795 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=86795&action=review

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:401
> +    _wrapCallFrames: function(callFrames)

_wrapCallFrames -> _createPresentationCallFrames ?

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:485
> +                callback(WebInspector.RemoteObject.fromPayload(result));

The callback should be called in any case even if there is an error.

> Source/WebCore/inspector/front-end/ScriptsPanel.js:352
> +            selectedCallFrame.evaluate(code, objectGroup, includeCommandLineAPI, callback);

You should report to the caller an error, otherwise the callback will not be invoked in some cases.

[Pavel Podivilov]

Committed r82234: <http://trac.webkit.org/changeset/82234>

[Andrey Adaikin]

View in context: https://bugs.webkit.org/attachment.cgi?id=87142&action=review

> Source/WebCore/inspector/front-end/DebuggerModel.js:188
> +        this._debuggerPausedDetails.callFrames = callFrames;

FYI. I keep seeing callFrames coming as an array of length 0, thus the first call of this callback is fine, but it sets a zero-length array to the this._debuggerPausedDetails.callFrames, which will cause an exception on a subsequent live edit commit. Here is a "pseudo" stack trace:

In the DebuggerPresentationModel.js @editScriptSource

  if (WebInspector.debuggerModel.callFrames)
    this._debuggerPaused();

This will fire an exception:
  callFrames[0].sourceLocation(didGetSourceLocation.bind(this));

because callFrames is defined, but of zero length.