Bug 57025 – [GTK] [PATCH] Avoid critical warning when free-ing list of plugins

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Priit Laes (IRC: plaes)]

Critical error is printed to console when there are no plugins present. This is because plugin list is stored inside GSList that is NULL by default (ie if no elements are present). But the function that free's the plugin list has g_return_if_fail(list) that emits the ciritical error when list is NULL.

[Priit Laes (IRC: plaes)]

Created attachment 86782 [details]
plugins-critical-warning-fix.patch

[WebKit Review Bot]

Attachment 86782 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/gtk/ChangeLog', u'Source/Web..." exit_code: 1

Source/WebKit/gtk/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Source/WebKit/gtk/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Priit Laes (IRC: plaes)]

Created attachment 86783 [details]
plugins-critical-warning-fix.patch

[WebKit Commit Bot]

Comment on attachment 86783 [details]
plugins-critical-warning-fix.patch

Clearing flags on attachment: 86783

Committed r81952: <http://trac.webkit.org/changeset/81952>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.