57025 – [GTK] [PATCH] Avoid critical warning when free-ing list of plugins

Bug 57025 - [GTK] [PATCH] Avoid critical warning when free-ing list of plugins

Summary: [GTK] [PATCH] Avoid critical warning when free-ing list of plugins

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	WebKitGTK (show other bugs)
Version:	528+ (Nightly build)
Hardware:	PC Linux

Importance:	P3 Normal
Assignee:	Nobody

URL:
Keywords:

Depends on:
Blocks:

Reported:	2011-03-24 09:28 PDT by Priit Laes (IRC: plaes)
Modified:	2011-03-25 03:33 PDT (History)
CC List:	3 users (show)

See Also:

Attachments
plugins-critical-warning-fix.patch (1.91 KB, patch) 2011-03-24 09:33 PDT, Priit Laes (IRC: plaes)	no flags	Details \| Formatted Diff \| Diff
plugins-critical-warning-fix.patch (1.93 KB, patch) 2011-03-24 09:37 PDT, Priit Laes (IRC: plaes)	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Priit Laes (IRC: plaes) 2011-03-24 09:28:05 PDT

Critical error is printed to console when there are no plugins present. This is because plugin list is stored inside GSList that is NULL by default (ie if no elements are present). But the function that free's the plugin list has g_return_if_fail(list) that emits the ciritical error when list is NULL.

Comment 1 Priit Laes (IRC: plaes) 2011-03-24 09:33:07 PDT

Created attachment 86782 [details]
plugins-critical-warning-fix.patch

Comment 2 WebKit Review Bot 2011-03-24 09:34:52 PDT

Attachment 86782 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/gtk/ChangeLog', u'Source/Web..." exit_code: 1

Source/WebKit/gtk/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Source/WebKit/gtk/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Priit Laes (IRC: plaes) 2011-03-24 09:37:01 PDT

Created attachment 86783 [details]
plugins-critical-warning-fix.patch

Comment 4 WebKit Commit Bot 2011-03-25 03:33:37 PDT

Comment on attachment 86783 [details]
plugins-critical-warning-fix.patch

Clearing flags on attachment: 86783

Committed r81952: <http://trac.webkit.org/changeset/81952>

Comment 5 WebKit Commit Bot 2011-03-25 03:33:42 PDT

All reviewed patches have been landed.  Closing bug.