Bug 57016 - [Qt] Avoid ASCII-cast warnings for WebKit.
Summary: [Qt] Avoid ASCII-cast warnings for WebKit.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Critical
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 57087
  Show dependency treegraph
 
Reported: 2011-03-24 08:14 PDT by Kristian Amlie
Modified: 2011-03-25 02:37 PDT (History)
5 users (show)

See Also:


Attachments
Avoided-ASCII-cast-warnings-for-WebKit (2.03 KB, patch)
2011-03-24 08:16 PDT, Kristian Amlie
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kristian Amlie 2011-03-24 08:14:26 PDT
Normally they won't be enabled anyway, but if you build webkit from within the Qt mother repository it will pick up Qt's default build settings, which do enable it. We need to disable them because warnings are treated as errors and there are way too many of them in the WebKit code.
Comment 1 Kristian Amlie 2011-03-24 08:16:45 PDT
Created attachment 86774 [details]
Avoided-ASCII-cast-warnings-for-WebKit
Comment 2 Benjamin Poulain 2011-03-24 10:23:19 PDT
Comment on attachment 86774 [details]
Avoided-ASCII-cast-warnings-for-WebKit

How many error do you get?
Could you create a task about removing that line?
Comment 3 WebKit Commit Bot 2011-03-24 10:48:02 PDT
Comment on attachment 86774 [details]
Avoided-ASCII-cast-warnings-for-WebKit

Clearing flags on attachment: 86774

Committed r81876: <http://trac.webkit.org/changeset/81876>
Comment 4 WebKit Commit Bot 2011-03-24 10:48:07 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2011-03-24 13:06:58 PDT
http://trac.webkit.org/changeset/81876 might have broken GTK Linux 32-bit Debug
The following tests are not passing:
svg/W3C-SVG-1.1/animate-elem-46-t.svg
svg/W3C-SVG-1.1/animate-elem-82-t.svg
Comment 6 Kristian Amlie 2011-03-25 00:21:04 PDT
(In reply to comment #2)
> (From update of attachment 86774 [details])
> How many error do you get?

I didn't count exactly, since it causes the build to fail. But in a parallel build, it stacked up quite a few.

> Could you create a task about removing that line?

https://bugs.webkit.org/show_bug.cgi?id=57087

(In reply to comment #5)
> http://trac.webkit.org/changeset/81876 might have broken GTK Linux 32-bit Debug
> The following tests are not passing:
> svg/W3C-SVG-1.1/animate-elem-46-t.svg
> svg/W3C-SVG-1.1/animate-elem-82-t.svg

I don't see how the submitted patch can have any effect on GTK. It doesn't even use qmake to build, does it?
Comment 7 Benjamin Poulain 2011-03-25 02:37:55 PDT
(In reply to comment #6)
> > Could you create a task about removing that line?
> 
> https://bugs.webkit.org/show_bug.cgi?id=57087

Thanks.
 
> (In reply to comment #5)
> > http://trac.webkit.org/changeset/81876 might have broken GTK Linux 32-bit Debug
> > The following tests are not passing:
> > svg/W3C-SVG-1.1/animate-elem-46-t.svg
> > svg/W3C-SVG-1.1/animate-elem-82-t.svg
> 
> I don't see how the submitted patch can have any effect on GTK. It doesn't even use qmake to build, does it?

Don't worry about that. The bot just send the alert for all the changes since the last successful testing.