Bug 57015 – [Qt] Make WebKit compile with modularized Qt with prefix

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Kristian Amlie]

This is needed for modularized Qt. It should be safe to remove QTDIR_build references, since building inside Qt will not be supported anymore.

[Kristian Amlie]

Created attachment 86773 [details]
Make-WebKit-compile-with-modularized-Qt-with-prefix

[Kristian Amlie]

Created attachment 86777 [details]
Make-WebKit-compile-with-modularized-Qt-with-prefix-v2

Small correction to ChangeLog.

[Benjamin Poulain]

Comment on attachment 86777 [details]
Make-WebKit-compile-with-modularized-Qt-with-prefix-v2

View in context: https://bugs.webkit.org/attachment.cgi?id=86777&action=review

> Source/JavaScriptCore/JavaScriptCore.pro:27
> +# Remove the following 2 lines if you want debug information in JavaScriptCore
> +CONFIG -= separate_debug_info
> +CONFIG += no_debug_info

Hey, you are now removing debug info systematically! How are we supposed to work? :)

[Kristian Amlie]

(In reply to comment #3)
> Hey, you are now removing debug info systematically! How are we supposed to work? :)

We just merged the two ways of building WebKit (inside and outside Qt) into one, and had to choose one approach. If you want us to remove it, we can also do that. Should I update the patch and take it away?

[Benjamin Poulain]

(In reply to comment #4)
> (In reply to comment #3)
> > Hey, you are now removing debug info systematically! How are we supposed to work? :)
> 
> We just merged the two ways of building WebKit (inside and outside Qt) into one, and had to choose one approach. If you want us to remove it, we can also do that. Should I update the patch and take it away?

Yes please.

I expect those who build webkit in debug to know what they do.

[Kristian Amlie]

Created attachment 86928 [details]
Make-WebKit-compile-with-modularized-Qt-with-prefix-v3

Removed the no_debug_info section entirely.

[Kristian Amlie]

Anything else needed from my side here, or is the patch ok?

[Alexis Menard (darktears)]

Comment on attachment 86928 [details]
Make-WebKit-compile-with-modularized-Qt-with-prefix-v3

View in context: https://bugs.webkit.org/attachment.cgi?id=86928&action=review

> ChangeLog:11
> +        https://bugs.webkit.org/show_bug.cgi?id=57015

This should be on the top like on http://trac.webkit.org/changeset/43259 or http://trac.webkit.org/changeset/83184 .

> Source/JavaScriptCore/ChangeLog:11
> +        https://bugs.webkit.org/show_bug.cgi?id=57015

Ditto.

> Source/WebCore/ChangeLog:11
> +        https://bugs.webkit.org/show_bug.cgi?id=57015

Ditto.

> Source/WebKit/qt/ChangeLog:11
> +        https://bugs.webkit.org/show_bug.cgi?id=57015

Ditto.

> Tools/ChangeLog:11
> +        https://bugs.webkit.org/show_bug.cgi?id=57015

Ditto.

[Kristian Amlie]

Created attachment 88777 [details]
Make-WebKit-compile-with-modularized-Qt-with-prefix-v4

[Kristian Amlie]

(In reply to comment #8)
> (From update of attachment 86928 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=86928&action=review
> 
> > ChangeLog:11
> > +        https://bugs.webkit.org/show_bug.cgi?id=57015
> 
> This should be on the top like on http://trac.webkit.org/changeset/43259 or http://trac.webkit.org/changeset/83184 .

Also created https://bugs.webkit.org/show_bug.cgi?id=58120, since prepare-ChangeLog does this wrong.

[Kristian Amlie]

FYI, I will be away for the next two weeks, so I will not respond during that time.

[Alexis Menard (darktears)]

Down-prioritize to P3 because the modularization project is a bit unknown state to us. We can revisit those patches after QtWebKit will find its way to Qt source tree.

[Eric Seidel (no email)]

I'm happy to rs=me this, but I suspect a qt person should offer an opinion.

[Kenneth Rohde Christiansen]

Adding some of our build geniuses :-)

[Alexis Menard (darktears)]

Comment on attachment 88777 [details]
Make-WebKit-compile-with-modularized-Qt-with-prefix-v4

I'll be happy to do an informal review and test but what is the procedure to test this? What is a modularized Qt with prefix? Is that still apply to Qt4?

[Csaba Osztrogonác]

I cc-ed Andras, AFAIK he has modularized Qt to check it.

[Jocelyn Turcotte]

Comment on attachment 88777 [details]
Make-WebKit-compile-with-modularized-Qt-with-prefix-v4

View in context: https://bugs.webkit.org/attachment.cgi?id=88777&action=review

> ChangeLog:8
> +        Make WebKit compile with modularized Qt with prefix

No need to repeat this line.

> Source/JavaScriptCore/JavaScriptCore.pro:-30
> -CONFIG(QTDIR_build) {
> -    # Remove the following 2 lines if you want debug information in JavaScriptCore
> -    CONFIG -= separate_debug_info
> -    CONFIG += no_debug_info
> -}
> -

- This should be synchronized with the same section in WebCore.pri.
- I don't think this should be completely removed though, this was a nice compromise for people, just wanting to use WebKit as a library, that have flacky linkers regarding memory space limits.
We really need this for debug SDK builds.

> Source/WebCore/features.pri:22
> -CONFIG(QTDIR_build) {
> +!isEmpty(QT_SOURCE_TREE) {

Do you know if this is always true for SDK builds?
In any case we can get that to work later if it doesn't.

[Benjamin Poulain]

Comment on attachment 88777 [details]
Make-WebKit-compile-with-modularized-Qt-with-prefix-v4

r- based on Jocelyn's comment.

[Csaba Osztrogonác]

Is this bug still valid?

[Tor Arne Vestbø]

Nope-