RESOLVED FIXED 57006
Web Inspector: Rework cpu-profiler-profiling.html to use capabilities of testing framework
https://bugs.webkit.org/show_bug.cgi?id=57006
Summary Web Inspector: Rework cpu-profiler-profiling.html to use capabilities of test...
Mikhail Naganov
Reported 2011-03-24 05:32:05 PDT
cpu-profiler-profiling.html test isn't aligned with the current approach of writing Inspector tests.
Attachments
patch (9.17 KB, patch)
2011-03-24 05:35 PDT, Mikhail Naganov
pfeldman: review+
mnaganov: commit-queue-
Mikhail Naganov
Comment 1 2011-03-24 05:35:17 PDT
Pavel Feldman
Comment 2 2011-03-24 11:13:32 PDT
Comment on attachment 86758 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=86758&action=review > LayoutTests/http/tests/inspector/profiler-test.js:1 > +var initialize_ProfilerTest = function() { should be moved to inspector/profiler
Mikhail Naganov
Comment 3 2011-03-25 00:13:57 PDT
(In reply to comment #2) > (From update of attachment 86758 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=86758&action=review > > > LayoutTests/http/tests/inspector/profiler-test.js:1 > > +var initialize_ProfilerTest = function() { > > should be moved to inspector/profiler Moved.
Mikhail Naganov
Comment 4 2011-03-25 00:19:05 PDT
Manually committed http://trac.webkit.org/changeset/81945 2011-03-24 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Pavel Feldman. Web Inspector: Rework cpu-profiler-profiling.html to use capabilities of testing framework. https://bugs.webkit.org/show_bug.cgi?id=57006 * http/tests/inspector/profiler-test.js: Added. (initialize_ProfilerTest.InspectorTest.startProfilerTest.startTest): (initialize_ProfilerTest.InspectorTest.startProfilerTest): (initialize_ProfilerTest.InspectorTest.completeProfilerTest): (initialize_ProfilerTest.InspectorTest.runProfilerTestSuite.runner): (initialize_ProfilerTest.InspectorTest.runProfilerTestSuite): (initialize_ProfilerTest): * inspector/cpu-profiler-profiling-expected.txt: Removed. * inspector/cpu-profiler-profiling.html: Removed. * inspector/profiler/cpu-profiler-profiling-expected.txt: Added. * inspector/profiler/cpu-profiler-profiling.html: Added.
Note You need to log in before you can comment on or make changes to this bug.