Bug 57001 - Web Inspector: brush up Network agent API.
Summary: Web Inspector: brush up Network agent API.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-24 02:59 PDT by Pavel Feldman
Modified: 2011-03-24 07:03 PDT (History)
13 users (show)

See Also:


Attachments
Patch (47.45 KB, patch)
2011-03-24 04:50 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-03-24 02:59:36 PDT
This bug will contain a couple of patches for network domain protocol beautification.
Comment 1 Pavel Feldman 2011-03-24 04:50:48 PDT
Created attachment 86757 [details]
Patch
Comment 2 Yury Semikhatsky 2011-03-24 05:40:02 PDT
Comment on attachment 86757 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86757&action=review

> LayoutTests/http/tests/inspector/network/network-redirect.html:36
> +        var dataGridNodes = WebInspector.panels.network._dataGrid.children;

swap this two lines?

> Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp:254
> +// FIXME: remove once not user downstream.

not user -> not used, also please file a bug for this and add its number next to the FIXME
Comment 3 Pavel Feldman 2011-03-24 06:28:21 PDT
Committed r81861: <http://trac.webkit.org/changeset/81861>
Comment 4 WebKit Review Bot 2011-03-24 07:03:04 PDT
http://trac.webkit.org/changeset/81861 might have broken Qt Linux Release
The following tests are not passing:
http/tests/inspector/network/network-redirect.html