Not sure if we should do this quite yet, but selectors 4 added :matches instead of :any. I'm interested to see what Mozilla folk think. I don't care either way. Both names seem fine. http://dev.w3.org/csswg/selectors4/#matches
Created attachment 97414 [details] Patch
Comment on attachment 97414 [details] Patch Why do you replace -webkit-any-link with -webkit-matches-link?
Comment on attachment 97414 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97414&action=review This review is just for nit-picking. I have no idea if this change is desirable so I'd like hear from expert folks... > LayoutTests/ChangeLog:4 > + Could you explain your change briefly? > LayoutTests/ChangeLog:8 > + Need a short description and bug URL (OOPS!) We don't need this line. > Source/WebCore/ChangeLog:7 > + You should mention about tests, even if you do't add any new test.
Created attachment 97428 [details] Patch
Comment on attachment 97414 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97414&action=review >> LayoutTests/ChangeLog:4 >> + > > Could you explain your change briefly? Done. >> LayoutTests/ChangeLog:8 >> + Need a short description and bug URL (OOPS!) > > We don't need this line. Removed it. >> Source/WebCore/ChangeLog:7 >> + > > You should mention about tests, even if you do't add any new test. Done.
I'm still not convinced we want to do this. By using :any we match Mozilla. Also, I'm increasingly of the opinion that :matches is a worse name. It's longer and less clear that it's an "or" relation versus an "and" relation. I suppose I should bring this up on the www-style mailing list and just get it resolved there.
Ojan, please write to www-style and r- this patch when you do.
Comment on attachment 97428 [details] Patch R- until this discussion is resolved. http://lists.w3.org/Archives/Public/www-style/2011Jun/0442.html
There has been recent activity in the CSSWG around :matches() and whether to rename it to better reflect its relationship with :not(). See these GitHub issue threads: https://github.com/w3c/csswg-drafts/issues/2143 https://github.com/w3c/csswg-drafts/issues/1027