Bug 56990 - rename -webkit-any to -webkit-matches
: rename -webkit-any to -webkit-matches
Status: NEW
Product: WebKit
Classification: Unclassified
Component: CSS
: 528+ (Nightly build)
: PC Mac OS X 10.5
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-23 20:39 PDT by Ojan Vafai
Modified: 2011-06-16 18:55 PDT (History)
6 users (show)

See Also:


Attachments
Patch (34.78 KB, patch)
2011-06-16 00:39 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff
Patch (32.01 KB, patch)
2011-06-16 02:50 PDT, Kentaro Hara
ojan: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-03-23 20:39:36 PDT
Not sure if we should do this quite yet, but selectors 4 added :matches instead of :any. I'm interested to see what Mozilla folk think. I don't care either way. Both names seem fine.

http://dev.w3.org/csswg/selectors4/#matches
Comment 1 Kentaro Hara 2011-06-16 00:39:26 PDT
Created attachment 97414 [details]
Patch
Comment 2 Kent Tamura 2011-06-16 02:09:47 PDT
Comment on attachment 97414 [details]
Patch

Why do you replace -webkit-any-link with -webkit-matches-link?
Comment 3 Hajime Morrita 2011-06-16 02:11:53 PDT
Comment on attachment 97414 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97414&action=review

This review is just for nit-picking. I have no idea if this change is desirable so I'd like hear from expert folks...

> LayoutTests/ChangeLog:4
> +

Could you explain your change briefly?

> LayoutTests/ChangeLog:8
> +        Need a short description and bug URL (OOPS!)

We don't need this line.

> Source/WebCore/ChangeLog:7
> +

You should mention about tests, even if you do't add any new test.
Comment 4 Kentaro Hara 2011-06-16 02:50:36 PDT
Created attachment 97428 [details]
Patch
Comment 5 Kentaro Hara 2011-06-16 02:54:12 PDT
Comment on attachment 97414 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97414&action=review

>> LayoutTests/ChangeLog:4
>> +
> 
> Could you explain your change briefly?

Done.

>> LayoutTests/ChangeLog:8
>> +        Need a short description and bug URL (OOPS!)
> 
> We don't need this line.

Removed it.

>> Source/WebCore/ChangeLog:7
>> +
> 
> You should mention about tests, even if you do't add any new test.

Done.
Comment 6 Ojan Vafai 2011-06-16 10:03:49 PDT
I'm still not convinced we want to do this. By using :any we match Mozilla. Also, I'm increasingly of the opinion that :matches is a worse name. It's longer and less clear that it's an "or" relation versus an "and" relation.

I suppose I should bring this up on the www-style mailing list and just get it resolved there.
Comment 7 Eric Seidel 2011-06-16 10:35:18 PDT
Ojan, please write to www-style and r- this patch when you do.
Comment 8 Ojan Vafai 2011-06-16 18:55:20 PDT
Comment on attachment 97428 [details]
Patch

R- until this discussion is resolved.

http://lists.w3.org/Archives/Public/www-style/2011Jun/0442.html