Bug 56990 - rename -webkit-any to -webkit-matches
: rename -webkit-any to -webkit-matches
Status: NEW
: WebKit
CSS
: 528+ (Nightly build)
: PC Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-03-23 20:39 PST by
Modified: 2011-06-16 18:55 PST (History)


Attachments
Patch (34.78 KB, patch)
2011-06-16 00:39 PST, Kentaro Hara
no flags Review Patch | Details | Formatted Diff | Diff
Patch (32.01 KB, patch)
2011-06-16 02:50 PST, Kentaro Hara
ojan: review-
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-03-23 20:39:36 PST
Not sure if we should do this quite yet, but selectors 4 added :matches instead of :any. I'm interested to see what Mozilla folk think. I don't care either way. Both names seem fine.

http://dev.w3.org/csswg/selectors4/#matches
------- Comment #1 From 2011-06-16 00:39:26 PST -------
Created an attachment (id=97414) [details]
Patch
------- Comment #2 From 2011-06-16 02:09:47 PST -------
(From update of attachment 97414 [details])
Why do you replace -webkit-any-link with -webkit-matches-link?
------- Comment #3 From 2011-06-16 02:11:53 PST -------
(From update of attachment 97414 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=97414&action=review

This review is just for nit-picking. I have no idea if this change is desirable so I'd like hear from expert folks...

> LayoutTests/ChangeLog:4
> +

Could you explain your change briefly?

> LayoutTests/ChangeLog:8
> +        Need a short description and bug URL (OOPS!)

We don't need this line.

> Source/WebCore/ChangeLog:7
> +

You should mention about tests, even if you do't add any new test.
------- Comment #4 From 2011-06-16 02:50:36 PST -------
Created an attachment (id=97428) [details]
Patch
------- Comment #5 From 2011-06-16 02:54:12 PST -------
(From update of attachment 97414 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=97414&action=review

>> LayoutTests/ChangeLog:4
>> +
> 
> Could you explain your change briefly?

Done.

>> LayoutTests/ChangeLog:8
>> +        Need a short description and bug URL (OOPS!)
> 
> We don't need this line.

Removed it.

>> Source/WebCore/ChangeLog:7
>> +
> 
> You should mention about tests, even if you do't add any new test.

Done.
------- Comment #6 From 2011-06-16 10:03:49 PST -------
I'm still not convinced we want to do this. By using :any we match Mozilla. Also, I'm increasingly of the opinion that :matches is a worse name. It's longer and less clear that it's an "or" relation versus an "and" relation.

I suppose I should bring this up on the www-style mailing list and just get it resolved there.
------- Comment #7 From 2011-06-16 10:35:18 PST -------
Ojan, please write to www-style and r- this patch when you do.
------- Comment #8 From 2011-06-16 18:55:20 PST -------
(From update of attachment 97428 [details])
R- until this discussion is resolved.

http://lists.w3.org/Archives/Public/www-style/2011Jun/0442.html