Bug 56974 – Services menu item to convert selected Simplified/Traditional Chinese Text is not working

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Enrica Casucci]

Repro steps:
1. Launch Safari and navigate to http://www.mozilla.org/editor/midasdemo/
2. Type "简体".
3. Control-click on the first character to bring up the context menu.
4. Choose "Convert Selected Simplified Chinese Text"

Expected

The character changes to 簡

Actual

The character is unchanged.

[Enrica Casucci]

I believe this regressed in http://trac.webkit.org/changeset/61794 where the readSelectionFromPasteboard method was removed from WebHTMLView.

[Enrica Casucci]

Created attachment 86719 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 86719 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86719&action=review

> Source/WebKit/mac/ChangeLog:11
> +        This methos and writeSelectionToPasteboard are needed to support Mac OS X

Typo: method.

> Source/WebKit/mac/WebView/WebHTMLView.mm:931
> +- (BOOL)readSelectionFromPasteboard:(NSPasteboard *)pasteboard 

It would be good to add a comment explaining that this method is not unused (same for matching "write" one).

[Alexey Proskuryakov]

<rdar://problem/8284642>

[Enrica Casucci]

(In reply to comment #3)
> (From update of attachment 86719 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=86719&action=review
> 
> > Source/WebKit/mac/ChangeLog:11
> > +        This methos and writeSelectionToPasteboard are needed to support Mac OS X
> 
> Typo: method.
> 
> > Source/WebKit/mac/WebView/WebHTMLView.mm:931
> > +- (BOOL)readSelectionFromPasteboard:(NSPasteboard *)pasteboard 
> 
> It would be good to add a comment explaining that this method is not unused (same for matching "write" one).

Done. Thanks for the review!

[Enrica Casucci]

Committed http://trac.webkit.org/changeset/81827.