Bug 56971 - new-run-webkit-tests: change up --worker-model defaults
Summary: new-run-webkit-tests: change up --worker-model defaults
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-23 15:40 PDT by Dirk Pranke
Modified: 2011-03-24 16:44 PDT (History)
6 users (show)

See Also:

Attachments
Patch (7.75 KB, patch)
2011-03-23 16:09 PDT, Dirk Pranke 		tony: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2011-03-23 15:40:07 PDT 
Currently Chromium Linux Hardy and Mac Leopard are still using the "old-inline" worker model. They should switch to the new model so I can delete the old code.
Comment 1 Dirk Pranke 2011-03-23 16:09:47 PDT 
Created attachment 86717 [details]
Patch
Comment 2 Dirk Pranke 2011-03-23 16:11:39 PDT 
Actually, they used the old-threads model, and mac defaulted to 1 child processes.

This change cleans up the defaults across the board. I've removed the warning message in the chromium-mac code since it's not likely to change at this point and leopard isn't getting a lot of usage apart from the bots.
Comment 3 Dirk Pranke 2011-03-24 15:14:16 PDT 
Committed r81908: <http://trac.webkit.org/changeset/81908>
Comment 4 WebKit Review Bot 2011-03-24 16:16:34 PDT 
http://trac.webkit.org/changeset/81908 might have broken Leopard Intel Debug (Tests)
Comment 5 Dirk Pranke 2011-03-24 16:36:13 PDT 
Indeed it did (python-tests). Fixing shortly.
Comment 6 Dirk Pranke 2011-03-24 16:44:54 PDT 
fixed in bug 57063.