WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
56971
new-run-webkit-tests: change up --worker-model defaults
https://bugs.webkit.org/show_bug.cgi?id=56971
Summary
new-run-webkit-tests: change up --worker-model defaults
Dirk Pranke
Reported
2011-03-23 15:40:07 PDT
Currently Chromium Linux Hardy and Mac Leopard are still using the "old-inline" worker model. They should switch to the new model so I can delete the old code.
Attachments
Patch
(7.75 KB, patch)
2011-03-23 16:09 PDT
,
Dirk Pranke
tony
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dirk Pranke
Comment 1
2011-03-23 16:09:47 PDT
Created
attachment 86717
[details]
Patch
Dirk Pranke
Comment 2
2011-03-23 16:11:39 PDT
Actually, they used the old-threads model, and mac defaulted to 1 child processes. This change cleans up the defaults across the board. I've removed the warning message in the chromium-mac code since it's not likely to change at this point and leopard isn't getting a lot of usage apart from the bots.
Dirk Pranke
Comment 3
2011-03-24 15:14:16 PDT
Committed
r81908
: <
http://trac.webkit.org/changeset/81908
>
WebKit Review Bot
Comment 4
2011-03-24 16:16:34 PDT
http://trac.webkit.org/changeset/81908
might have broken Leopard Intel Debug (Tests)
Dirk Pranke
Comment 5
2011-03-24 16:36:13 PDT
Indeed it did (python-tests). Fixing shortly.
Dirk Pranke
Comment 6
2011-03-24 16:44:54 PDT
fixed in
bug 57063
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug