RESOLVED FIXED 56965
[chromium] Add traceEvents to compositor 
https://bugs.webkit.org/show_bug.cgi?id=56965
Summary [chromium] Add traceEvents to compositor
Nat Duca
Reported 2011-03-23 15:13:17 PDT
[chromium] Add traceEvents to compositor
Attachments
Patch (8.01 KB, patch)
2011-03-23 15:18 PDT, Nat Duca 		no flags
DetailsFormatted DiffDiff
Patch (10.40 KB, patch)
2011-03-23 19:07 PDT, Nat Duca 		no flags
DetailsFormatted DiffDiff
Patch (10.39 KB, patch)
2011-03-24 10:25 PDT, Nat Duca 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nat Duca
Comment 1 2011-03-23 15:18:05 PDT
Created attachment 86705 [details] Patch
Kenneth Russell
Comment 2 2011-03-23 17:46:07 PDT
Comment on attachment 86705 [details] Patch I think it would be better to add a helper class in WebCore/platform/chromium/ which calls PlatformBridge's traceEventBegin in its constructor and traceEventEnd in its destructor, and stack allocate it where desired. This patch seems too brittle.
Nat Duca
Comment 3 2011-03-23 19:07:43 PDT
Created attachment 86732 [details] Patch
Nat Duca
Comment 4 2011-03-23 19:08:35 PDT
Not sure how to address the style bot warning about MAKE_UNIQUE_IDENTIFIER.
WebKit Review Bot
Comment 5 2011-03-23 19:10:09 PDT
Attachment 86732 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/chromium/TraceEvent.h:39: TRACE_EVENT_MAKE_UNIQUE_IDENTIFIER is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kenneth Russell
Comment 6 2011-03-23 19:40:23 PDT
Comment on attachment 86732 [details] Patch You should feel free to file a bug against check-webkit-style, but it looks like it doesn't handle multi-line #defines correctly. If you just make the TRACE_EVENT macro a single line it will clean up the style error. This is worth doing.
Nat Duca
Comment 7 2011-03-24 10:25:52 PDT
Created attachment 86792 [details] Patch
Kenneth Russell
Comment 8 2011-03-24 10:30:14 PDT
Comment on attachment 86792 [details] Patch Looks great.
WebKit Commit Bot
Comment 9 2011-03-24 12:02:48 PDT
Comment on attachment 86792 [details] Patch Clearing flags on attachment: 86792 Committed r81881: <http://trac.webkit.org/changeset/81881>
WebKit Commit Bot
Comment 10 2011-03-24 12:02:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.